Fix url serialization for unions #11227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
3faf897
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://115555ee.pydantic-docs.pages.dev |
| Branch Preview URL: | https://fix-url-ser.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11227 will degrade performances by 22.46%Comparing Summary
Benchmarks breakdown
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Viicos
approved these changes
Jan 8, 2025
sydney-runkle
added a commit
that referenced
this pull request
Jan 8, 2025
Specifically, we've made the serialization for url types more strict. If a non-url type is passed into the serializer, we raise an unexpected value warning instead of just blindly attempting to stringify the input. This results in more intuitive behavior for serializing unions with url types.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11211
We want to make sure that non-url type data passed to url serialization logic raises a warning, just like we do for the custom ip types, see:
pydantic/pydantic/_internal/_generate_schema.py
Line 462 in a2eb22b
This makes it such that serialization of data having union types like
HttpUrl | strprefers thestrtype when appropriate.