Recursively unpack Literal values if using PEP 695 type aliases
#11114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
fde4552
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76e0a2d4.pydantic-docs.pages.dev |
| Branch Preview URL: | https://literal-type-aliases.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11114 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Dec 16, 2024
pydantic/_internal/_typing_extra.py
Outdated
| # Note: we could also check for generic aliases with a type alias as an origin. | ||
| # However, it is very unlikely that this happens as type variables can't appear in | ||
| # `Literal` forms, so the only valid (but unnecessary) use case would be something like: | ||
| # `type Test[T] = Literal['a']` (and then use `Test[int]`). |
There was a problem hiding this comment.
Did you mean to use a str literal here?
There was a problem hiding this comment.
Yes, if you do:
type Test[T] = Literal['whatever']
MyLit = Literal[Test[int]]MyLit.__args__[0] is a GenericAlias instance, and here we only check for is_type_alias_type. But as I mentioned in the comment it is very unlikely to encounter such use cases, as it is not necessary (the type variable is useless here as you can't do something like type Test[T] = Literal[T]).
cc3186a to
b2f4844
Compare
b2f4844 to
fde4552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #9269.
Related issue number
Checklist