8000 Fix host required enforcement for urls to be compatible with v2.9 behavior by sydney-runkle · Pull Request #11027 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Fix host required enforcement for urls to be compatible with v2.9 behavior #11027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

sydney-runkle
Copy link
Contributor
@sydney-runkle sydney-runkle commented Dec 2, 2024

Fix #10968
Fix #11007

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 2, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e46677a
Status: ✅  Deploy successful!
Preview URL: https://a58d7e09.pydantic-docs.pages.dev
Branch Preview URL: https://networks-host-fixes.pydantic-docs.pages.dev

View logs

Copy link
codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #11027 will not alter performance

Comparing networks-host-fixes (e46677a) with main (b25095f)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor
github-actions bot commented Dec 2, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  networks.py 711, 853
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member
@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, hopefully will fix most of the remaining url issues.

@sydney-runkle sydney-runkle merged commit aee6057 into main Dec 2, 2024
55 checks passed
@sydney-runkle sydney-runkle deleted the networks-host-fixes branch December 2, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't override constraints with annotations in version 2.10 In 2.10.x AnyUrl does not validate data uris
2 participants
0