8000 Set fields when `defer_build` is set on Pydantic dataclasses by Viicos · Pull Request #10984 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Set fields when defer_build is set on Pydantic dataclasses #10984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Viicos
Copy link
Member
@Viicos Viicos commented Nov 26, 2024

This aligns with Pydantic models, where only the schema generation is deferred.

Also fix some comments.

Fixes #10953.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48ff78b
Status: ✅  Deploy successful!
Preview URL: https://278bde39.pydantic-docs.pages.dev
Branch Preview URL: https://dataclass-defer-build-fields.pydantic-docs.pages.dev

View logs

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 26, 2024
Copy link
codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #10984 will not alter performance

Comparing dataclass-defer-build-fields (48ff78b) with main (6f31f8f)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _dataclasses.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor
@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the simple fix!

@sydney-runkle sydney-runkle merged commit 120d7bc into main Dec 2, 2024
55 checks passed
@sydney-runkle sydney-runkle deleted the dataclass-defer-build-fields branch December 2, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
2 participants
0