8000 Fix JSON schema title when specified as `''` by sydney-runkle · Pull Request #10936 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Fix JSON schema title when specified as '' 8000 #10936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sydney-runkle
Copy link
Contributor

Sort of edge case condition here, but easy to fix #10935

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 22, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8cf772f
Status: ✅  Deploy successful!
Preview URL: https://804c10da.pydantic-docs.pages.dev
Branch Preview URL: https://json-schema-blank-title-fix.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle enabled auto-merge (squash) November 22, 2024 00:04
@sydney-runkle sydney-runkle merged commit ed29a35 into main Nov 22, 2024
50 checks passed
@sydney-runkle sydney-runkle deleted the json-schema-blank-title-fix branch November 22, 2024 00:07
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #10936 will not alter performance

Comparing json-schema-blank-title-fix (8cf772f) with main (309d4ed)

Summary

✅ 46 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.10: Blank model title no longer respected by generated JSON schema
2 participants
0