8000 Add `trailing-strings` support to `experimental_allow_partial` by sydney-runkle · Pull Request #10825 · pydantic/pydantic · GitHub
[go: up one dir, main page]
< 8000 div data-turbo-body class="logged-out env-production page-responsive" style="word-wrap: break-word;" >
Skip to content

Add trailing-strings support to experimental_allow_partial #10825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 4 commits into from
Nov 12, 2024
Merged

Add trailing-strings support to experimental_allow_partial #10825

sydney-runkle merged 4 commits into from
Nov 12, 2024

Conversation

@sydney-runkle
Copy link
Contributor
@sydney-runkle sydney-runkle commented Nov 12, 2024

Fixes #10806

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 12, 2024
@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Nov 12, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea16e10
Status: ✅  Deploy successful!
Preview URL: https://64d541b0.pydantic-docs.pages.dev
Branch Preview URL: https://exp-allow-partial.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle added relnotes-feature relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed relnotes-fix Used for bugfixes. relnotes-change Used for changes to existing functionality which don't have a better categorization. labels Nov 12, 2024
@codspeed-hq
Copy link
codspeed-hq bot commented Nov 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10825 will not alter performance

Comparing exp-allow-partial (ea16e10) with main (ff4a325)

Summary

✅ 44 untouched benchmarks

@sydney-runkle sydney-runkle mentioned this pull request Nov 12, 2024
Merged
@github-actions
Copy link
Contributor
github-actions bot commented Nov 12, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

samuelcolvin
samuelcolvin approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member
@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

sydney-runkle and others added 2 commits November 12, 2024 13:59
@sydney-runkle @samuelcolvin
Code review suggestions
927b30d 
Co-authored-by: Samuel Colvin <s@muelcolvin.com>
@sydney-runkle
more trailing strings docs
ea16e10
@sydney-runkle sydney-runkle enabled auto-merge (squash) November 12, 2024 19:06
@sydney-runkle sydney-runkle merged commit 4eecee7 into main Nov 12, 2024
52 checks passed
@sydney-runkle sydney-runkle deleted the exp-allow-partial branch November 12, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees

No one assigned

Labels

relnotes-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow partial needs 'trailing-strings' mode, same as pydantic_core.from_json

3 participants

@sydney-runkle @samuelcolvin
0