8000 Tweak internal logic of `ValidateCallWrapper` by Viicos · Pull Request #10633 · pydantic/pydantic · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@Viicos
Copy link
Member
@Viicos Viicos commented Oct 15, 2024

Review from #10627.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos requested a review from sydney-runkle October 15, 2024 15:58
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 15, 2024
@Viicos Viicos changed the title weak internal logic of ValidateCallWrapper Tweak internal logic of ValidateCallWrapper Oct 15, 2024
@Viicos Viicos force-pushed the validate-call-quickfix branch from 6cd12ff to 068aad5 Compare October 15, 2024 15:58
@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Oct 15, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 068aad5
Status: ✅  Deploy successful!
Preview URL: https://fa18f0a4.pydantic-docs.pages.dev
Branch Preview URL: https://validate-call-quickfix.pydantic-docs.pages.dev

View logs

Copy link
Contributor
@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up :)

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 15, 2024 16:02
@sydney-runkle sydney-runkle added relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels Oct 15, 2024
@codspeed-hq
Copy link
codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #10633 will not alter performance

Comparing validate-call-quickfix (068aad5) with main (51cf3cb)

Summary

✅ 44 untouched benchmarks

@github-actions
Copy link
Contributor
github-actions bot commented Oct 15, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@sydney-runkle sydney-runkle merged commit 7bb0e0a into main Oct 15, 2024
@sydney-runkle sydney-runkle deleted the validate-call-quickfix branch October 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0