8000 Support usage of `type` with `typing.Self` and type aliases by kc0506 · Pull Request #10621 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Support usage of type with typing.Self and type aliases #10621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 17, 2024
Merged

Support usage of type with typing.Self and type aliases #10621

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b91cfd2
fix
kc0506 Oct 14, 2024
2b448f2
add edge cases
kc0506 Oct 14, 2024
746f0ab
fix error < 3.11
kc0506 Oct 14, 2024
dbe73b9
revert some changes
kc0506 Oct 14, 2024
a66c684
Replace `type` with `Type`
kc0506 Oct 14, 2024
3376355
Rerun CI
kc0506 Oct 14, 2024
09bd231
fix again
kc0506 Oct 14, 2024
a6418bd
add test for TypeAlias
kc0506 Oct 14, 2024
fbc2ac7
Apply suggestions from code review
kc0506 Oct 15, 2024
df14e81
add eval_str for _get_args_resolving_forward_refs
kc0506 Oct 16, 2024
a3b6e8a
Merge branch 'main' into fix-type-of-self
kc0506 Oct 16, 2024
98ab66a
Revert "add eval_str for _get_args_resolving_forward_refs"
kc0506 Oct 17, 2024
44123f3
add another workaround
kc0506 Oct 17, 2024
5fef1a9
re-organize tests of type[]
kc0506 Oct 17, 2024
7ca3e0d
fix broken test
kc0506 Oct 17, 2024
57a2004
fix broken test again
kc0506 Oct 17, 2024
b2b75a3
Apply suggestions from code review
kc0506 Oct 17, 2024
be40b6d
clean up errors
kc0506 Oct 17, 2024
12a9c26
add comment back
kc0506 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix broken test again
  • Loading branch information
@kc0506
kc0506 committed Oct 17, 2024
commit 57a20041d0edb86ca41d18fb7edecb72e9ffccbf
2 changes: 1 addition & 1 deletion tests/test_types_self.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def self_types1(self) -> List[Type[Self]]:

# make sure forward refs are supported:
@computed_field
def self_types2(self) -> list[type['Self']]:
def self_types2(self) -> List[Type['Self']]:
return [type(self), self.self_type]

@computed_field
Expand Down
Loading
0