Use b64decode and b64encode for Base64Bytes type
#10486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
3b80ba9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://617bf15e.pydantic-docs.pages.dev |
| Branch Preview URL: | https://base-64-bytes-fix.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10486 will not alter performanceComparing Summary
|
Contributor
Author
|
One lingering concern that I have here is the failing test relating to round tripping: from pydantic import BaseModel, Base64Bytes
input_data = b'Zm9vIGJhcg==\n'
expected_value = b'foo bar'
class Model(BaseModel):
base64_value: Base64Bytes
m = Model(base64_value=input_data)
assert m.base64_value == expected_value
assert m.model_dump()['base64_value'] == input_data
# b'Zm9vIGJhcg==' != b'Zm9vIGJhcg==\n' |
Viicos
reviewed
Sep 25, 2024
b64decode and b64encode for Base64Bytes type
Contributor
Author
We've discussed - this isn't an issue, the whole point was to move to the newer function not adding a newline automatically. Validation still succeeds, so round tripping is fine. This is similar to url behavior, etc. |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
|
Thank you @sydney-runkle, this is fantastic! |
commonism
added a commit
to commonism/aiopenapi3
that referenced
this pull request
Jan 11, 2025
commonism
added a commit
to commonism/aiopenapi3
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9072
Change that should be highlighted in the upcoming release notes + blog post.