Breaking Change: Fix JSON Schema generation for constrained dates #10185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`(exclusive)Minimum/Maximum` is not applicable
5 tasks
Deploying pydantic-docs with
|
| Latest commit: |
061ce39
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8bd2c11c.pydantic-docs.pages.dev |
| Branch Preview URL: | https://json-schema-date.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10185 will not alter performanceComparing Summary
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Aug 20, 2024
Contributor
There was a problem hiding this comment.
Looks good, thanks! I've changed the title of the PR to reflect the breaking nature to make sure we document this in the release notes.
Contributor
|
@Viicos, is there any other way to express these constraints for |
Member
Author
|
What we need is json-schema-org/json-schema-spec#116, seems like it isn't going to happen unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change, but the previously generated JSON Schema was:
So I think we should document the breaking change but not do any deprecation process.
Change Summary
Related issue number
Checklist