8000 Fix JSON Schema `number` type for literal and enum schemas by Viicos · Pull Request #10172 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Fix JSON Schema number type for literal and enum schemas #10172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sydney-runkle merged 1 commit into from
Aug 19, 2024
Merged

Fix JSON Schema number type for literal and enum schemas #10172

sydney-runkle merged 1 commit into from
Aug 19, 2024

Conversation

@Viicos
Copy link
Member
@Viicos Viicos commented Aug 19, 2024

Change Summary

Fixes #10163

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 19, 2024
@Viicos Viicos mentioned this pull request Aug 19, 2024
Closed
1 task
@cloudflare-workers-and-pages
Copy link
cloudflare-workers-and-pages bot commented Aug 19, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 47d2b5b
Status: ✅  Deploy successful!
Preview URL: https://809441ce.pydantic-docs.pages.dev
Branch Preview URL: https://10163.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link
8000
codspeed-hq bot commented Aug 19, 2024

CodSpeed Performance Report

Merging #10172 will not alter performance

Comparing 10163 (47d2b5b) with main (823d51f)

Summary

✅ 17 untouched benchmarks

@github-actions
Copy link
Contributor
github-actions bot commented Aug 19, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

sydney-runkle
sydney-runkle approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor
@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sydney-runkle sydney-runkle merged commit 061e62c into main Aug 19, 2024
@sydney-runkle sydney-runkle deleted the 10163 branch August 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSON Schema serialization of FloatEnums incorrectly assigns type 'numeric'

3 participants

@Viicos @sydney-runkle
0