8000 Using cached internal import for `BaseModel` by sydney-runkle · Pull Request #10013 · pydantic/pydantic · GitHub
[go: up one dir, main page]
Skip to content

Using cached internal import for BaseModel #10013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sydney-runkle merged 13 commits into from
Aug 1, 2024
Merged

Using cached internal import for BaseModel #10013

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
467c5dc
try out cached component
sydney-runkle Jul 31, 2024
7faea5f
don't need functools cache
sydney-runkle Jul 31, 2024
a0e3e42
class based approach
sydney-runkle Aug 1, 2024
039a4e9
needed parens
sydney-runkle Aug 1, 2024
97b7dfd
try expanding imports
sydney-runkle Aug 1, 2024
3423542
renaming, adding a module fetch
sydney-runkle Aug 1, 2024
50a8246
removing decorators changes
sydney-runkle Aug 1, 2024
5474169
simple cached approach
sydney-runkle Aug 1, 2024
5a58a88
switch order
sydney-runkle Aug 1, 2024
1a7ce82
lru cache
sydney-runkle Aug 1, 2024
9875623
initial work for FieldInfo as well
sydney-runkle Aug 1, 2024
7efc506
remove unnecessary local import in hot loop
sydney-runkle Aug 1, 2024
0597cba
fill in gaps w cached field infos
sydney-runkle Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary local import in hot loop
  • Loading branch information
@sydney-runkle
sydney-runkle committed Aug 1, 2024
commit 7efc506d59ca66b1e058ee6aedbb51dcb94b1024
4 changes: 1 addition & 3 deletions pydantic/_internal/_generate_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
)
from typing_extensions import Annotated, Literal, TypeAliasType, TypedDict, get_args, get_origin, is_typeddict

from ..aliases import AliasGenerator
from ..aliases import AliasChoices, AliasGenerator, AliasPath
from ..annotated_handlers import GetCoreSchemaHandler, GetJsonSchemaHandler
from ..config import ConfigDict, JsonDict, JsonEncoder
from ..errors import PydanticSchemaGenerationError, PydanticUndefinedAnnotation, PydanticUserError
Expand Down Expand Up @@ -1254,8 +1254,6 @@ def _common_field_schema( # C901
self, name: str, field_info: FieldInfo, decorators: DecoratorInfos
) -> _CommonField:
# Update FieldInfo annotation if appropriate:
from .. import AliasChoices, AliasPath

FieldInfo = import_cached_field_info()

if has_instance_in_type(field_info.annotation, (ForwardRef, str)):
Expand Down
0