8000 main.c, sflash_diskio.c: get flash size by call to spi_flash_get_chip_size() by robert-hh · Pull Request #162 · pycom/pycom-micropython-sigfox · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

main.c, sflash_diskio.c: get flash size by call to spi_flash_get_chip_size() #162

Closed
wants to merge 2 commits into from
Closed

Conversation

robert-hh
Copy link
Contributor

Instead of guessing it by ESP revision number. Even if the result from spi_flash_get_chip_size() could be
used directly here, the same logic is used in sflash_diskio.c and main.c to avoid inconsistencies.
The change in sflash_diskio.c was already implemented in previous versions but got lost or was dropped intentionally.

robert-hh added 2 commits May 1, 2018 08:10
Instead of guessing it by ESP revision number.
Even if the result from spi_flash_get_chip_size() could be
used directly here, the same logic is used as in sflash_diskio.c
to avoid inconsistencies.
@robert-hh
Copy link
Contributor Author

@Xykon There are problems with integration checks since a few days: continuous-integration/jenkins/pr-head

@robert-hh robert-hh closed this Sep 12, 2018
@robert-hh
Copy link
Contributor Author

Does not work as expected.

peter-pycom added a commit that referenced this pull request Aug 25, 2020
X-Ryl669 pushed a commit to X-Ryl669/pycom-micropython-sigfox that referenced this pull request May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0