This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Added hostname configuration to WLAN module #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added hostname configuration
ep1cman
reviewed
Nov 20, 2017
| @@ -410,8 +410,7 @@ STATIC void mptask_update_lpwan_mac_address (void) { | |||
| #endif | |||
|
|
|||
| STATIC void mptask_enable_wifi_ap (void) { | |||
| wlan_setup (WIFI_MODE_AP, DEFAULT_AP_SSID, WIFI_AUTH_WPA2_PSK, DEFAULT_AP_PASSWORD, | |||
| DEFAULT_AP_CHANNEL, ANTENNA_TYPE_INTERNAL, true); | |||
| wlan_setup (WIFI_MODE_AP, DEFAULT_AP_SSID, WIFI_AUTH_WPA2_PSK, DEFAULT_AP_PASSWORD, DEFAULT_AP_CHANNEL, ANTENNA_TYPE_INTERNAL, true, "illysky"); | |||
There was a problem hiding this comment.
the illysky default should be changed to something more appropriate to all users
There was a problem hiding this comment.
Ah yes! Sorry forgot about that. Perhaps “Pycom” or “MicroPython”.
|
why hostname have limit to 16 chars? i see that it is declared in tcpip_adapter.h as |
peter-pycom
added a commit
that referenced
this pull request
Feb 28, 2020
Update pybytes for release
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
Update pybytes for release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hostname when creating WLAN STA or AP object. Useful for getting the device IP address from router attached devices. Overrides “espressif” hostname.
eg,
from network import WLAN
w = WLAN(mode=WLAN.STA, hostname=“Pycom”)
I’ve limited the hostname to 16 characters, not sure what the limit should be off top of my head.
Cheers