10000 MEMORY LEAKAGE | LoPy | 1.15.0.b1 | OSError: [Errno 12] ENOMEM - wifis = wlan.scan() · Issue #136 · pycom/pycom-micropython-sigfox · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

MEMORY LEAKAGE | LoPy | 1.15.0.b1 | OSError: [Errno 12] ENOMEM - wifis = wlan.scan() #136

Closed
danieleftodi opened this issue Feb 8, 2018 · 10 comments
Closed

MEMORY LEAKAGE | LoPy | 1.15.0.b1 | OSError: [Errno 12] ENOMEM - wifis = wlan.scan() #136

danieleftodi opened this issue Feb 8, 2018 · 10 comments

Comments

@danieleftodi
Copy link

(sysname='LoPy', nodename='LoPy', release='1.15.0.b1', version='v1.8.6-849-baa8c33 on 2018-01-29', machine='LoPy with ESP32', lorawan='1.0.0')

Traceback (most recent call last):
File "main.py", line 129, in
OSError: [Errno 12] ENOMEM

Line 129 :: wifis = wlan.scan()
@danieleftodi
Copy link
Author

When in a place where there are many Wi-Fi's ... it crashes ... as it run out of memory to allocate.

Before scanning for Wi-fis ... FREE MEM 35808 ....

@danieleftodi danieleftodi changed the title LoPy | 1.15.0.b1 | OSError: [Errno 12] ENOMEM - wifis = wlan.scan() MEMORY LEAKAGE | LoPy | 1.15.0.b1 | OSError: [Errno 12] ENOMEM - wifis = wlan.scan() Feb 8, 2018
@danieleftodi
Copy link
Author

When in a place where there are many Wi-Fi's ... it crashes ... as it run out of memory to allocate.

Before scanning for Wi-fis ... FREE MEM 35808 ....

@danieleftodi
Copy link
Author
danieleftodi commented Feb 9, 2018 •
edited
Loading

So I found the offending code:

File: modwlan.c
Line: 742 --> 750

uint16_t ap_num;
wifi_ap_record_t *ap_record_buffer;
wifi_ap_record_t *ap_record;

esp_wifi_scan_get_ap_num(&ap_num); // get the number of scanned APs
ap_record_buffer = pvPortMalloc(ap_num * sizeof(wifi_ap_record_t));
if (ap_record_buffer == NULL) {
    mp_raise_OSError(MP_ENOMEM);
}

You assume "ap_num" and "wifi_ap_record_t" to always be higher then Zero ...

This is logically a bad thing to do ... as in multiplication Samething multiplied by Zero will always become Null!!!!!

Ergo:
ap_record_buffer = pvPortMalloc(ap_num * sizeof(wifi_ap_record_t));

Will most likely sometimes become NULL as "ap_num" == NULL ...

And it turns out that we might sometimes be in places on planet earth where we won't ever see any "APs" ... ergo "ap_num" == NULL ...

@danieleftodi
Copy link
Author

For a 1st, I've added a Try-catch ... so we catch the error, so it won't crash the app.

try:
    wifis = wlan.scan()
except OSError:
    wifis = None
    print('-----------------------------------------------------------------------------')
    print("DEBUG :: Try-catch :: Wi-Fi.scan() OSError :: FREE MEM " + str(gc.mem_free()))
    print('-----------------------------------------------------------------------------')

Also, working on a patch ... for the firmware....

@danicampora
Copy link

@danieleftodi thanks for pointing this one out. I've fixed and it will be ready for the next release.

@danieleftodi
Copy link
Author

@danicampora ... about when will you release a new firmware? (wondering, since we are in a time crunch :-) ....)

@danicampora
Copy link

@danieleftodi it's planned for tomorrow end of the day :-)

@danieleftodi
Copy link
Author

Great :-D

@danieleftodi
Copy link
Author

@danicampora

Hi again, could you please share a link to the new firmware for LoPy?

Since,

https://software.pycom.io/downloads/LoPy_868-1.16.0.b1.tar.gz

doesn't seem to work :-(

1 similar comment
@danieleftodi
Copy link
Author

@danicampora

Hi again, could you please share a link to the new firmware for LoPy?

Since,

https://software.pycom.io/downloads/LoPy_868-1.16.0.b1.tar.gz

doesn't seem to work :-(
9637

@danieleftodi danieleftodi reopened this Feb 15, 2018
peter-pycom added a commit that referenced this issue Jul 9, 2020
@peter-pycom
Merge pull request #136 from pycom/v1.20.2.rc9_Dev_againagain
09446ac 
pull hotfixes back from pms:Dev
X-Ryl669 pushed a commit to X-Ryl669/pycom-micropython-sigfox that referenced this issue May 12, 2023
@peter-pycom
Merge pull request pycom#136 from pycom/v1.20.2.rc9_Dev_againagain
ae4dd97 
pull hotfixes back from pms:Dev
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danicampora @danieleftodi
0