8000 Clean up tests using context by EmilyBourne · Pull Request #2308 · pyccel/pyccel · GitHub
[go: up one dir, main page]
Skip to content

Clean up tests using context #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: devel
Choose a base branch
from
Draft

Clean up tests using context #2308

wants to merge 12 commits into from

Conversation

EmilyBourne
Copy link
Member
@EmilyBourne EmilyBourne commented May 3, 2025 •
edited
Loading

Use the new functionalities allowing Pyccel to use context variables to remove unnecessary reimports.

Commit Summary

  • Stop making exceptions for reimported when checking for disabled pylint commands
  • Ensure functions imported from recognised modules can be recognised from the context
  • Remove repeated imports

@pyccel-bot
Copy link
pyccel-bot bot commented May 3, 2025

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

8000

@EmilyBourne
Copy link
Member Author

/bot run pylint pyccel_lint

@EmilyBourne
Copy link
Member Author
EmilyBourne commented May 3, 2025 •
edited
Loading

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@EmilyBourne EmilyBourne marked this pull request as ready for review May 3, 2025 08:45
@github-actions github-actions bot marked this pull request as draft May 3, 2025 08:51
@pyccel-bot
Copy link
pyccel-bot bot commented May 3, 2025

Unfortunately your PR is not passing the tests so it is not quite ready 8000 for review yet. Let me know when it is fixed with /bot mark as ready.

@EmilyBourne
Copy link
Member Author

/bot run linux

@EmilyBourne
Copy link
Member Author

/bot run linux

@EmilyBourne
Copy link
Member Author

/bot run linux

@EmilyBourne EmilyBourne marked this pull request as ready for review May 3, 2025 12:55
@github-actions github-actions bot marked this pull request as draft May 3, 2025 13:02
@pyccel-bot
Copy link
pyccel-bot bot commented May 3, 2025

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EmilyBourne
0