8000 Flexible Instance Naming in Class Methods. by sboof911 · Pull Request #1479 · pyccel/pyccel · GitHub
[go: up one dir, main page]
Skip to content

Flexible Instance Naming in Class Methods. #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: devel
Choose a base branch
from
Draft

Flexible Instance Naming in Class Methods. #1479

wants to merge 6 commits into from

Conversation

sboof911
Copy link
Member
@sboof911 sboof911 commented Aug 7, 2023 •
edited
Loading

Change the hard code of self to the first argument passed in the methods.
Removing the condition on the first argument passed in a method of a class.

8000
@pyccel-bot
Copy link
pyccel-bot bot commented Aug 7, 2023 •
edited by sboof911
Loading

Hello again! Thank you for this new pull request 🤩.

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@sboof911 sboof911 linked an issue Aug 7, 2023 that may be closed by this pull request
Flexible Instance Naming in Class Methods. #1471
Open
@sboof911
Copy link
Member Author
sboof911 commented Aug 7, 2023

/bot tests

@pyccel-bot
Copy link
pyccel-bot bot commented Aug 7, 2023

This bot reacts to all comments which begin with /bot. This phrase can be followed by any of these commands:

  • show tests : Lists the tests which can be triggered
  • run X : Triggers the test X (acceptable values for X can be seen using show tests). Multiple tests can be specified separated by spaces.
  • try V X : Triggers the test X (acceptable values for X can be seen using show tests) using Python version V. Multiple tests can be specified separated by spaces, but all will use the same Python version.
  • mark as ready : Runs the PR tests. If they pass then it adds the appropriate review flag and requests reviews. This command should be used when the PR is first ready for review, or when a review has been answered.
  • commands : Shows this list detailing all the commands which are understood.
  • trust user X : Tells the bot that a new user X is trusted to run workflows (prevents misuse of GitHub actions for mining etc). This command can only be used by a trusted reviewer.
  • accept coverage : Tells the bot that the coverage errors have been investigated and cannot be fixed in this PR.

Beware: if you have never contributed to this repository and you are not a member of the Pyccel organisation, the bot will ignore all requests to run tests until permitted by a trusted reviewer.

@sboof911
Copy link
Member Author
sboof911 commented Aug 7, 2023

/bot show tests

@pyccel-bot
Copy link
pyccel-bot bot commented Aug 7, 2023

The following is a list of keywords which can be used to run tests. Tests in bold are run by pull requests when they are marked as ready for review or pushed to while not in draft:

  • linux : Runs the unit tests on a Linux system.
  • windows : Runs the unit tests on a Windows system.
  • macosx : Runs the unit tests on a MacOS X system.
  • coverage : Runs the unit tests on a Linux system and checks the coverage of the tests.
  • docs : Checks if the documentation follows the numpydoc format.
  • pylint : Runs pylint on files which are too big to be handled by codacy.
  • pyccel_lint : Runs a linter to check that Pyccel's best practices are followed.
  • spelling : Checks if everything in the documentation is spelled (and capitalised) correctly.
  • pr_tests : Runs all the tests marked in bold.
  • pickle : Checks that .pyccel files have been correctly generated and installed by the installation process.
  • editable_pickle : Checks that .pyccel files have been correctly generated and installed by the editable installation process.
  • pickle_wheel : Checks that .pyccel files have been correctly generated and packaged into the wheel.
  • linux_anaconda : Runs the unit tests on a linux system using anaconda for python.
  • windows_anaconda : Runs the unit tests on a windows system using anaconda for python.

These tests can be run with the command /bot run X (multiple tests can be specified separated by spaces), or with try V X to test on Python version V.

@sboof911
Copy link
Member Author
sboof911 commented Aug 7, 2023

/bot run coverage docs pylint pyccel_lint spelling

@sboof911 sboof911 mentioned this pull request Aug 7, 2023
Merged
pyccel-bot[bot]
pyccel-bot bot approved these changes Aug 7, 2023
View reviewed changes
Copy link
@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@sboof911
Copy link
Member Author
sboof911 commented Aug 7, 2023

/bot run pyccel_lint

@sboof911
Copy link
Member Author
sboof911 commented Aug 7, 2023

/bot run docs pylint spelling

@sboof911
Copy link
Member Author
sboof911 commented Aug 7, 2023

/bot run pr_tests

@sboof911
Copy link
Member Author
sboof911 commented Aug 7, 2023

/bot run pr_tests

pyccel-bot[bot]
pyccel-bot bot approved these changes Aug 7, 2023
View reviewed changes
Copy link
@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@sboof911 sboof911 requested a review from mkaddani August 7, 2023 15:49
@yguclu
Copy link
Member
yguclu commented Aug 25, 2023

@sboof911 Is this PR ready for review?

@EmilyBourne EmilyBourne mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyccel-bot pyccel-bot[bot] pyccel-bot[bot] approved these changes

@mkaddani mkaddani Awaiting requested review from mkaddani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Classes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flexible Instance Naming in Class Methods.
2 participants
@sboof911 @yguclu
0