style: use Unpack for better kwargs typing#599
Merged
tlambert03 merged 5 commits intopyapp-kit:mainfrom Oct 10, 2023
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 87.68% 87.85% +0.16%
==========================================
Files 39 39
Lines 4573 4561 -12
==========================================
- Hits 4010 4007 -3
+ Misses 563 554 -9
☔ View full report in Codecov by Sentry. |
Unpack for kwargs typingUnpack for better kwargs typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR uses Unpack to provide nicer static IDE completion for all the places where widget kwargs are passed through a chain of super calls.
These changes have no runtime effects