Replace QSpinBox with QLargeIntSpinBox#572
Merged
tlambert03 merged 5 commits intopyapp-kit:mainfrom Aug 12, 2023
Merged
Conversation
The range of QSpinBox is limited to a 32-bit signed integer - Python integers can go much larger than that. By using QLargeIntSpinBox instead, we can go much larger
tlambert03
approved these changes
Jul 28, 2023
Member
There was a problem hiding this comment.
Thanks! LGTM assuming everything passes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 38 38
Lines 4466 4466
=======================================
Hits 3977 3977
Misses 489 489
☔ View full report in Codecov by Sentry. |
Member
|
ok, this is pretty much ready to go. The failing napari/stardist/partseg tests are all because napari installs are failing at the moment, and unrelated to magicgui. The ubuntu-latest (3.9) pyqt5 is a legitimate superqt issue, but since it only appears to (repeatedly) happen on the specific combination of ubuntu/pyqt5/python3.9, it's a bit hard to test and fix. might just skip it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The range of QSpinBox is limited to a 32-bit signed integer - Python integers can go much larger than that. By using QLargeIntSpinBox instead, we enable larger range options!