E528 feat: support Pydantic2 (as well as Pydantic1) by tlambert03 · Pull Request #570 · pyapp-kit/magicgui · GitHub
[go: up one dir, main page]

Skip to content

feat: support Pydantic2 (as well as Pydantic1)#570

Merged
tlambert03 merged 15 commits intopyapp-kit:mainfrom
tlambert03:pydantic2
Aug 6, 2023
Merged

feat: support Pydantic2 (as well as Pydantic1)#570
tlambert03 merged 15 commits intopyapp-kit:mainfrom
tlambert03:pydantic2

Conversation

@tlambert03
Copy link
Member

No description provided.

@codecov
Copy link
codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 55.76% and project coverage change: -0.69% ⚠️

Comparison is base (1809a0e) 89.73% compared to head (a41b8b8) 89.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   89.73%   89.05%   -0.69%     
==========================================
  Files          37       38       +1     
  Lines        4422     4466      +44     
==========================================
+ Hits         3968     3977       +9     
- Misses        454      489      +35     
Files Changed Coverage Δ
src/magicgui/schema/_ui_field.py 85.01% <55.76%> (-11.88%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jni
Copy link
Contributor
jni commented Jul 25, 2023

@tlambert03 Just for casual observers it might be soothing to rename this PR to "Support both Pydantic v1 and v2" 😅

@tlambert03 tlambert03 changed the title feat: support Pydantic2 feat: support Pydantic2 (as well as Pydantic2) Jul 25, 2023
@tlambert03 tlambert03 changed the title feat: support Pydantic2 (as well as Pydantic2) feat: support Pydantic2 (as well as Pydantic1) Jul 25, 2023
@tlambert03
Copy link
Member Author

surely you don't think the guy who tried to raise the alarm bells about the dangers of hard-pinned pydantic2 requirements would just move to pydantic2 in a package that napari uses! 😅

@tlambert03 tlambert03 merged commit eff4e27 into pyapp-kit:main Aug 6, 2023
@tlambert03 tlambert03 deleted the pydantic2 branch August 6, 2023 14:09
@tlambert03 tlambert03 added the enhancement New feature or request label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0