Change exception to not confuse static code checkers#550
Change exception to not confuse static code checkers#550tlambert03 merged 2 commits intopyapp-kit:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=======================================
Coverage 89.75% 89.76%
=======================================
Files 37 37
Lines 4433 4434 +1
=======================================
+ Hits 3979 3980 +1
Misses 454 454
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
oh how interesting and vaguely annoying 😂 I'm fine with this in this case, # some_file.py
"""Module docstring."""
from magicgui.widgets import Container
class SearchLabel(Container):
"""Some Widget."""
def __init__(self) -> None:
super().__init__(layout='vertical') |
|
going to merge, since I have no issues with this. But if you can give me a config to reproduce that'd be great |
|
hm. The screenshot comes from deepsource https://deepsource.io/gh/4DNucleome/PartSeg/run/f3260ef2-a55e-44b4-9b58-5cca538e70c8/python/PYL-W0223?listindex=0 I just copied your file, updated pylint to the latest one, and call Do you know how to dump configuration? |
When using
NotImplementedError, the static code checkers like pylint marks a method as required to implement in a subclass. I suggest changing toRuntimeError(but I'm not glued to this selection of exception class).