8000 fix: catch warning from future version of psygnal by tlambert03 · Pull Request #531 · pyapp-kit/magicgui · GitHub
[go: up one dir, main page]

Skip to content

fix: catch warning from future version of psygnal#531

Merged
tlambert03 merged 2 commits intopyapp-kit:mainfrom
tlambert03:on_ref_err
Feb 20, 2023
Merged

fix: catch warning from future version of psygnal#531
tlambert03 merged 2 commits intopyapp-kit:mainfrom
tlambert03:on_ref_err

Conversation

@tlambert03
Copy link
Member
@tlambert03 tlambert03 commented Feb 20, 2023

relates to a warning that will appear after pyapp-kit/psygnal#178

@codecov
Copy link
codecov bot commented Feb 20, 2023

Codecov Report

Base: 89.86% // Head: 89.84% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2c59f47) compared to base (7cce77e).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   89.86%   89.84%   -0.02%     
==========================================
  Files          39       39              
  Lines        4438     4442       +4     
==========================================
+ Hits         3988     3991       +3     
- Misses        450      451       +1     
Impacted Files Coverage Δ
src/magicgui/schema/_guiclass.py 96.66% <80.00%> (-1.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 changed the title catch warning from future version of psygnal chore: catch warning from future version of psygnal Feb 20, 2023
@tlambert03 tlambert03 changed the title chore: catch warning from future version of psygnal test: catch warning from future version of psygnal Feb 20, 2023
@tlambert03 tlambert03 changed the title test: catch warning from future version of psygnal fix: catch warning from future version of psygnal Feb 20, 2023
@tlambert03 tlambert03 merged commit b74a28f into pyapp-kit:main Feb 20, 2023
@tlambert03 tlambert03 deleted the on_ref_err branch February 20, 2023 14:16
@tlambert03 tlambert03 added the bug Something isn't working label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0