10000 fixed imports and keys by jetheurer · Pull Request #94 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@jetheurer
Copy link
Contributor

added import datetime; changed key from Alpha_sc to alpha_sc

@wholmgren
Copy link
Member

@jetheurer I took a very brief look at your notebooks and it's not clear to me what's different. Can you provide a description of what you've changed? git diff does not work well with IPython notebooks, unfortunately.

@jetheurer
Copy link
Contributor Author

They were very simple changes. In one notebook I added import datetime and in another i changed the dictionary key from Alpha_sc to alpha_sc

But I ran all the notebooks again to be sure they worked -- so I think that's why the diff is so confusing.

@wholmgren
Copy link
Member

Thanks for clarification. That Alpha_sc issue is due to the new sam files in #80.

wholmgren added a commit that referenced this pull request Nov 2, 2015
@wholmgren wholmgren merged commit f435b6e into pvlib:master Nov 2, 2015
@wholmgren wholmgren added this to the 0.2.2 milestone Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0