8000 update to numpy-1.12.0 by mikofski · Pull Request #830 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

update to numpy-1.12.0 #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2019
Merged

update to numpy-1.12.0 #830

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fb75bb
update to numpy-1.12.0
mikofski Dec 4, 2019
69f6da2
update what's new to require numpy >= 1.12.0
mikofski Dec 9, 2019
79e728a
update both pandas and numpy requirements
mikofski Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update what's new to require numpy >= 1.12.0
  • Loading branch information
@mikofski
mikofski authored Dec 9, 2019
commit 69f6da278ae0d8f4ea76dee3a59500012cb21320
9 changes: 7 additions & 2 deletions docs/sphinx/source/whatsnew/v0.7.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ recommend all users of v0.6.3 upgrade to this release after checking API
compatibility notes.

**Python 2.7 support ended on June 1, 2019.** (:issue:`501`)
**Minimum numpy version is now 1.10.4. Minimum pandas version is now 0.18.1.**
**Minimum numpy version is now 1.12.0. Minimum pandas version is now 0.18.1.**

API Breaking Changes
~~~~~~~~~~~~~~~~~~~~
Expand All @@ -30,7 +30,7 @@ API Changes with Deprecations
- `temperature.sapm_cell` returns only the cell temperature, whereas the
old `pvsystem.sapm_celltemp` returned a `DataFrame` with both cell and module temperatures.
- Created `temperature.sapm_module` to return module temperature using the SAPM temperature model.
- Changed the order of arguments for`pvsystem.sapm_celltemp`,
- Changed the order of arguments for `pvsystem.sapm_celltemp`,
`pvsystem.pvsyst_celltemp` and `PVSystem.sapm_celltemp` to be consistent
among cell temperature model functions.
- Removed `model` as a kwarg from `temperature.sapm_cell` and
Expand Down Expand Up @@ -187,6 +187,10 @@ Removal of prior version deprecations
* Removed `ModelChain.singlediode` method.
* Removed `ModelChain.prepare_inputs` clearsky assumption when no irradiance
data was provided.

Requirements
~~~~~~~~~~~~
* pvlib now requires numpy >= 1.12.0, released in 2017. (:issue:`830`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this new section for numpy but not include python or pandas? I'm not opposed to the section, just looking for consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was just looking for examples of a section that talked about the changes in requirements, I copied this from v0.4 requirements which was the only example I could find. I only addressed numpy because that's what's in #830.

Does v0.7 also change pandas requirments? There's already a section in bold at the top which states the Python, Pandas, and NumPy requirements, but I'm happy to repeat it down here too or just remove this section if it's redundant? I don't know what's best, so if you have a strong opinion, I happy with whatever you would like to see here. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does v0.7 also change pandas requirments? There's already a section in bold at the top which states the Python, Pandas, and NumPy requirements

Yes, they've all changed which is why they are up there in bold. But it seems that we need to do a better job of making that clear. pandas puts dependency changes like these in warning boxes. I don't know if that's overdoing it or not. Maybe something like "pandas requirement increased to" would be more clear than "pvlib now requires"?

I don't have a strong opinion other than we should be consistent within this file. And the bikeshed should be white.


Contributors
~~~~~~~~~~~~
Expand All @@ -202,3 +206,4 @@ Contributors
* Joseph Ranalli (:ghuser:`jranalli`)
* Tony Lorenzo (:ghuser:`alorenzo175`)
* Todd Karin (:ghuser:`toddkarin`)
* Mark Mikofski (:ghuser:`mikofski`)
0