-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Create iam.py, consistent naming for IAM functions #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
73f4638
move iam functions to iam.py
cwhanse a89cc01
move function tests to test_iam.py
cwhanse 0f1c90c
adjust PVSystem methods, add deprecation for functions and PVSystem m…
cwhanse 0a55b54
adjust PVSystem tests, test for function deprecation
cwhanse 8505a0d
move sapm aoi function, adjust ModelChain methods
cwhanse f48742c
remove _ typo
cwhanse 1bcde31
lint fixes
cwhanse c51bc08
move fixture to correct place
cwhanse 5e01712
move sapm_module_params fixture to conftest.py
cwhanse e5bebe1
fix cut/paste errors
cwhanse 549fc2c
add missing keys to fixture, add missing text to pvsystem.sapm docstring
cwhanse 42210e4
fix and update pvsystem.sapm tests
cwhanse 1475db6
remove DataFrame test for sapm, lint fixes
cwhanse 006768d
implement PVSystem.get_iam, add deprecation test for pvsystem.sapm_ao…
cwhanse c10af4c
lint
cwhanse b9e39ac
Merge branch 'master' into iam
cwhanse ab1fbbc
test fixes, add Material to sapm_module_params fixture
cwhanse 4dadd4b
test fixes
cwhanse 7f14c95
add martin_ruiz to modelchain
cwhanse 9164592
finish adding martin_ruiz to modelchain
cwhanse 2fe7396
add test for ModelChain.infer_aoi_model, improve coverage
cwhanse 3d6bcf5
repair delete mistake
cwhanse 64a6b3c
test for invalid aoi model parameters in ModelChain
cwhanse 152ef7a
update api, whatsnew
cwhanse 46db9d7
test fix
cwhanse ea6fe81
fixture for aoi_model tests
cwhanse 2529351
bad indent
cwhanse f641cd0
docstring and lint
cwhanse f331949
lint
cwhanse ec723c6
module docstring, changes to tests
cwhanse cf998ea
test fixes
cwhanse 23f2677
another test fix
cwhanse 1e63f04
improve coverage
cwhanse 5fb7cc8
fix exception test
cwhanse b43b28c
fix the fix
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
<
10000
div style="left: -107px; top: -7px" data-view-component="true" class="Popover-message Box position-relative mx-auto text-left color-shadow-large p-2 mt-2">
Diff view
Diff view
test fixes
- Loading branch information
commit cf998ea4357fb08012fc196bc088f6cd215d42c4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ModelChain
initialization is complicated enough that we should probably be more careful in this test by adding a check for the right text in the message. Something like: