8000 fix python 3.7 build on travis by wholmgren · Pull Request #634 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

fix python 3.7 build on travis #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2018
Merged

fix python 3.7 build on travis #634

merged 4 commits into from
Dec 12, 2018

Conversation

wholmgren
Copy link
Member
  • no issue
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

We've been seeing issues with the spa.py file on the Python 3.7 build on Travis for a few months. The error is related to resizing some arrays in place. For some reason, this works fine on Python 2.7 - 3.6 and but fails on some platforms on 3.7. I could never reproduce it locally on my mac or linux machines. This PR takes a different approach to resizing the arrays.

Worked on my fork, hopefully works in this PR...

@wholmgren wholmgren added this to the 0.6.1 milestone Dec 12, 2018
@wholmgren wholmgren requested a review from cwhanse December 12, 2018 19:34
@cwhanse cwhanse merged commit 70032ab into pvlib:master Dec 12, 2018
@wholmgren wholmgren deleted the fixtravis37 branch December 12, 2018 22:02
@wholmgren wholmgren mentioned this pull request Jan 31, 2019
Closed
@wholmgren wholmgren mentioned this pull request Feb 22, 2019
Merged
@wholmgren wholmgren mentioned this pull request Mar 6, 2019
Closed
mabounassif pushed a commit to mabounassif/pvlib-python that referenced this pull request Feb 7, 2020
@wholmgren @mabounassif
fix python 3.7 build on travis (pvlib#634)
09eb469 
* update try python 3.7

* 3.7dev

* new resize operation

* whats new, comment
mabounassif pushed a commit to mabounassif/pvlib-python that referenced this pull request Feb 7, 2020
@wholmgren @mabounassif
fix python 3.7 build on travis (pvlib#634)
90fd3bf 
* update try python 3.7

* 3.7dev

* new resize operation

* whats new, comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhanse cwhanse cwhanse approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wholmgren @cwhanse
0