8000 improve forecast test reliability by wholmgren · Pull Request #303 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

improve forecast test reliability #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2017
Merged

improve forecast test reliability #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a20675d
put conda-forge first in fx builds
wholmgren Feb 4, 2017
97576bf
add pytest timeout
wholmgren Feb 4, 2017
3197552
add skip windows
wholmgren Feb 5, 2017
50b7d8d
update whatsnew
wholmgren Feb 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/requirements-py27.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: test_env
channels:
- conda-forge
- defaults
- http://conda.anaconda.org/conda-forge
dependencies:
- python=2.7
- numpy
Expand All @@ -16,3 +16,4 @@ dependencies:
- nose
- pip:
- coveralls
- pytest-timeout
3 changes: 2 additions & 1 deletion ci/requirements-py34.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: test_env
channels:
- defaults
- conda-forge
- defaults
dependencies:
- python=3.4
- numpy
Expand All @@ -16,3 +16,4 @@ dependencies:
- nose
- pip:
- coveralls
- pytest-timeout
3 changes: 2 additions & 1 deletion ci/requirements-py35.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: test_env
channels:
- defaults
- conda-forge
- defaults
dependencies:
- python=3.5
- numpy
Expand All @@ -16,3 +16,4 @@ dependencies:
- nose
- pip:
- coveralls
- pytest-timeout
9 changes: 9 additions & 0 deletions docs/sphinx/source/whatsnew/v0.4.4.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ Documentation
* Fixes broken Classes link in the v0.3.0 documentation.


Bug fixes
~~~~~~~~~

* Resolved several issues with the forecast module tests. Library import
errors were resolved by prioritizing the conda-forge channel over the
default channel. Stalled ci runs were resolved by adding a timeout to
the HRRR_ESRL test. (:issue:`293`)


Contributors
~~~~~~~~~~~~

Expand Down
3 changes: 3 additions & 0 deletions pvlib/test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
import pytest


skip_windows = pytest.mark.skipif('win' in sys.platform,
reason='does not run on windows')

try:
import scipy
has_scipy = True
Expand Down
7 changes: 5 additions & 2 deletions pvlib/test/test_forecast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import pytest
from numpy.testing import assert_allclose

from conftest import requires_siphon, has_siphon
from conftest import requires_siphon, has_siphon, skip_windows

pytestmark = pytest.mark.skipif(not has_siphon, reason='requires siphon')

Expand All @@ -30,7 +30,10 @@
_end = _start + pd.Timedelta(days=1)
_modelclasses = [
GFS, NAM, HRRR, NDFD, RAP,
pytest.mark.xfail(HRRR_ESRL, reason="HRRR_ESRL is unreliable")]
skip_windows(
pytest.mark.xfail(
pytest.mark.timeout(HRRR_ESRL, timeout=60),
reason="HRRR_ESRL is unreliable"))]
_working_models = []
_variables = ['temp_air', 'wind_speed', 'total_clouds', 'low_clouds',
'mid_clouds', 'high_clouds', 'dni', 'dhi', 'ghi',]
Expand Down
0