8000 NREL bird clearsky by mikofski · Pull Request #276 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

NREL bird clearsky #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
May 26, 2017
Merged

NREL bird clearsky #276

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
9d192ba
add requirements.txt to install into virtualenv and ignore venv/
mikofski Dec 3, 2016
457615d
add Bird clearsky model
mikofski Dec 3, 2016
048a837
move test_bird to test_clearsky and move bird to clearsky core module
mikofski Dec 15, 2016
1324267
revert api changes
mikofski Dec 15, 2016
f985b15
add spencer and pvcdron eot to solarposition, fix test and 2pi
mikofski Dec 17, 2016
3ace2a8
add equation of time test
mikofski Jan 7, 2017
850b604
addressing comments in PR 276
mikofski Jan 10, 2017
3b86fd8
add declination formulas to solarposition.py
mikofski Jan 10, 2017
dc4eba6
make bird function signature similar to other clearsky methods
mikofski Jan 11, 2017
ba7eb1e
add all parameters to docstring for bird clearsky
mikofski Jan 11, 2017
e6dcdac
add all parameters to docstring for bird clearsky
mikofski Jan 11, 2017
8877fb0
set night values to zero
mikofski Jan 11, 2017
de0eb33
calculate diffuse_horiz return value prior to return line
mikofski Jan 11, 2017
da8e292
update test_bird() with new function signature
mikofski Jan 14, 2017
b8d93cf
Merge branch 'master' into nrel_bird_clearsky
mikofski Jan 14, 2017
0e69eca
Merge branch 'master' into nrel_bird_clearsky
mikofski Jan 14, 2017
dd97ecc
update docs
mikofski Jan 14, 2017
96af6a7
add missing requirements
mikofski Jan 14, 2017
926c28b
add it to min build too
mikofski Jan 14, 2017
ca7649e
remove dependence on xlrd
mikofski Jan 21, 2017
f2fc729
move low precision solar position correlations to new api section
mikofski Jan 23, 2017
977bc8f
test keywords in bird clear sky model
mikofski Jan 23, 2017
09d0b7e
test scalars in bird model
mikofski Jan 23, 2017
cb562ef
add test data file
mikofski Jan 23, 2017
1976721
Merge branch 'master' into nrel_bird_clearsky
mikofski Feb 4, 2017
bc5eb18
lower case Spencer71 in docs and solarposition
mikofski Feb 4, 2017
a4b9edd
Merge branch 'master' into nrel_bird_clearsky
mikofski Feb 7, 2017
76db3c7
Merge branch 'master' into nrel_bird_clearsky
mikofski May 17, 2017
513cd95
fix lower case 's' in spencer71
mikofski May 17, 2017
dc528be
output OrderedDict or DataFrame
mikofski May 17, 2017
ca8adf8
fix link
mikofski May 17, 2017
1e14e5f
update docstring returns to OrderedDict/DataFrame
mikofski May 18, 2017
b4e5cce
provide note on solar vs apparent zenith and testing
mikofski May 18, 2017
2a0458a
quotes for 'direct_horizontal' in docstring returns
mikofski May 18, 2017
eafb9cd
add tests for solarposition low-accuracy formulas
mikofski May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into nrel_bird_clearsky
  • Loading branch information
@mikofski
mikofski committed May 17, 2017
commit 76db3c7950323fe1bbf792d0343ae9371be6a276
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.4.4.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ Enhancements
~~~~~~~~~~~~

* Added NREL Bird clear sky model. (:issue:`276`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're onto 0.4.5

* Added Anton Driesse Inverter database and made compatible with
pvsystem.retrieve_sam. (:issue:`169`)
* Ported Anton Driesse Inverter model from PV_LIB Toolbox. (:issue:`160`)
* Added Kasten pyrheliometric formula to calculate Linke turbidity factors with
improvements by Ineichen and Perez to extend range of air mass (:issue:`278`)
* Added coefficients for CIGS and a-Si modules types to the
Expand Down
11 changes: 5 additions & 6 deletions pvlib/solarposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import numpy as np
import pandas as pd
import datetime

from pvlib import atmosphere
from pvlib.tools import datetime_to_djd, djd_to_datetime
Expand Down Expand Up @@ -275,8 +274,8 @@ def spa_python(time, latitude, longitude,
using time.year and time.month from pandas.DatetimeIndex.
For most simulations specifing delta_t is sufficient.
Difference between terrestrial time and UT1.
*Note*: delta_t = None will break code using nrel_numba,
this will be fixed in a future version.
*Note: delta_t = None will break code using nrel_numba,
this will be fixed in a future version.*
The USNO has historical and forecasted delta_t [3].
atmos_refrac : float, optional
The approximate atmospheric refraction (in degrees)
Expand Down Expand Up @@ -817,8 +816,8 @@ def nrel_earthsun_distance(time, how='numpy', delta_t=67.0, numthreads=4):
using time.year and time.month from pandas.DatetimeIndex.
For most simulations specifing delta_t is sufficient.
Difference between terrestrial time and UT1.
*Note*: delta_t = None will break code using nrel_numba,
this will be fixed in a future version.
*Note: delta_t = None will break code using nrel_numba,
this will be fixed in a future version.*
By default, use USNO historical data and predictions

numthreads : int, optional
Expand Down Expand Up @@ -1126,7 +1125,7 @@ def hour_angle(times, longitude, equation_of_time):
equation_of_time_pvcdrom
"""
hours = np.array([(t - t.tz.localize(
datetime.datetime(t.year, t.month, t.day)
dt.datetime(t.year, t.month, t.day)
)).total_seconds() / 3600. for t in times])
timezone = times.tz.utcoffset(times).total_seconds() / 3600.
return 15. * (hours - 12. - timezone) + longitude + equation_of_time / 4.
You are viewing a condensed version of this merge commit. You can view the full changes here.
0