8000 Update FAQ URL by eljpsm · Pull Request #2488 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Update FAQ URL #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2025
Merged

Update FAQ URL #2488

merged 4 commits into from
Jun 20, 2025

Conversation

eljpsm
Copy link
Contributor
@eljpsm eljpsm commented Jun 20, 2025 •
edited
Loading
  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I noticed that the FAQ URL is currently broken. I think this updated one is what it should be, but let me know if this is incorrect!

AdamRJensen
AdamRJensen approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member
@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add yourself to the author list in the whatsnew file

eljpsm and others added 2 commits June 20, 2025 20:25
@eljpsm @AdamRJensen
Update README.md
a6e8deb 
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
@eljpsm
Update whatsnew file
76b4466
@eljpsm
Copy link
Contributor Author
eljpsm commented Jun 20, 2025

@AdamRJensen Thanks! Would you like me to rebase this PR into one commit?

@AdamRJensen
Copy link
Member

@AdamRJensen Thanks! Would you like me to rebase this PR into one commit?

No need

@kandersolar kandersolar added this to the v0.13.1 milestone Jun 20, 2025
kandersolar
kandersolar approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member
@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eljpsm!

@kandersolar kandersolar merged commit dfafe6d into pvlib:main Jun 20, 2025
2 checks passed
@echedey-ls echedey-ls mentioned this pull request Jun 20, 2025
Open
@eljpsm eljpsm deleted the update-faq-url branch June 21, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamRJensen AdamRJensen AdamRJensen approved these changes

@kandersolar kandersolar kandersolar approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v0.13.1
Development

Successfully merging this pull request may close these issues.
3 participants
@eljpsm @AdamRJensen @kandersolar
0