10000 Make `i_x` and `i_xx` SAPM parameters optional by kandersolar · Pull Request #2433 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Make i_x and i_xx SAPM parameters optional #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025
Merged

Make i_x and i_xx SAPM parameters optional #2433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37d3fcc
make C4-C7 optional in pvlib.pvsystem.sapm
kandersolar Apr 10, 2025
a773130
make optional in PVSystem and ModelChain as well
kandersolar Apr 10, 2025
98cdcea
incidental cleanup
kandersolar Apr 10, 2025
c8532cc
whatsnew
kandersolar Apr 10, 2025
0103952
lint
kandersolar Apr 10, 2025
cf551e7
make IXO and IXXO optional too
kandersolar Apr 11, 2025
e0ac4c5
Merge branch 'main' into sapm-ixx
kandersolar Apr 11, 2025
9c7f962
Merge branch 'main' into sapm-ixx
kandersolar Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@kandersolar
kandersolar committed Apr 10, 2025
commit 0103952235befbcdf72f3fefde06ab523c672c0a
2 changes: 1 addition & 1 deletion tests/test_modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,7 +1767,7 @@ def test_sapm_optional_params(sapm_dc_snl_ac_system, location):
for array in sapm_dc_snl_ac_system.arrays:
for key in ['C4', 'C5', 'C6', 'C7']:
array.module_parameters.pop(key)

# no error:
ModelChain(sapm_dc_snl_ac_system, location)

Expand Down
2 changes: 1 addition & 1 deletion tests/test_pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def test_sapm(sapm_module_params):
}
out = pvsystem.sapm(effective_irradiance, temp_cell, params_no_c4c7)
assert 'i_x' not in out.keys()
assert 'i_xx' not in out.keys()
assert 'i_xx' not in out.keys()


def test_PVSystem_sapm(sapm_module_params, mocker):
Expand Down
0