Change default method in Location.get_sun_rise_set_transit #2410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
approved these changes
Mar 14, 2025
6 tasks
kandersolar
reviewed
Mar 15, 2025
kandersolar
97B0
approved these changes
Mar 15, 2025
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.I would like to suggest that we switch the default method of
pvlib.location.Location.get_sun_rise_set_transittospainstead ofpyephem.The main reason is that I think it's annoying that we're defaulting to a method that requires the installation of an optional external package when we have functions within pvlib that can do this.
Also, as pointed out by @cwhanse in #1631 (comment), the pyephem package is in maintenance-only mode, which is another reason not to rely to much on this.