8000 Remove expired `read_tmy3` deprecations by kandersolar · Pull Request #2408 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Remove expired read_tmy3 deprecations #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2025
Merged

Remove expired read_tmy3 deprecations #2408

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99ec7f1
nix `recolumn`; default `map_variables` to `True`
kandersolar Mar 14, 2025
9bbfbc0
ditch the associated tests
kandersolar Mar 14, 2025
f4951fd
whatsnew
kandersolar Mar 14, 2025
b697d2e
remove unused imports
kandersolar Mar 14, 2025
e01a2da
more whatsnew
kandersolar Mar 14, 2025
3459829
Merge branch 'main' into read_tmy3-recolumn
kandersolar Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ditch the associated tests
  • Loading branch information
@kandersolar
kandersolar committed Mar 14, 2025
commit 9bbfbc07900bc14b9a9358d64827c4ad6c48c3f8
17 changes: 0 additions & 17 deletions tests/iotools/test_tmy.py
8000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,11 @@ def test_read_tmy3():
tmy.read_tmy3(TMY3_TESTFILE, map_variables=False)


def test_read_tmy3_recolumn():
with warnings.catch_warnings():
warnings.simplefilter("ignore")
data, meta = tmy.read_tmy3(TMY3_TESTFILE, recolumn=True)
assert 'GHISource' in data.columns


def test_read_tmy3_norecolumn():
data, _ = tmy.read_tmy3(TMY3_TESTFILE, map_variables=False)
assert 'GHI source' in data.columns


def test_read_tmy3_raise_valueerror():
with pytest.raises(ValueError, match='`map_variables` and `recolumn`'):
_ = tmy.read_tmy3(TMY3_TESTFILE, recolumn=True, map_variables=True)


def test_read_tmy3_map_variables():
data, meta = tmy.read_tmy3(TMY3_TESTFILE, map_variables=True)
assert 'ghi' in data.columns
Expand All @@ -55,11 +43,6 @@ def test_read_tmy3_map_variables():
assert 'precipitable_water' in data.columns


def test_read_tmy3_map_variables_deprecating_warning():
with pytest.warns(pvlibDeprecationWarning, match='names will be renamed'):
data, meta = tmy.read_tmy3(TMY3_TESTFILE)


def test_read_tmy3_coerce_year():
coerce_year = 1987
data, _ = tmy.read_tmy3(TMY3_TESTFILE, coerce_year=coerce_year,
Expand Down
0