10000 Adopt `dni_clear` variable name for clearsky DNI by RDaxini · Pull Request #2274 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Adopt dni_clear variable name for clearsky DNI #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 10, 2024
Merged

Adopt dni_clear variable name for clearsky DNI #2274

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bc5a7ad
irradiance.py: dirint_bins(), dirindex()
RDaxini Oct 21, 2024
d431aa8
irradiance.py: dni(), _get_dirint_coeffs(), complete_irradiance()
RDaxini Oct 21, 2024
2701cbb
modify tests
RDaxini Oct 25, 2024
4906f4f
apply decorator: dirindex, dni, complete irradiance
RDaxini Nov 26, 2024
34b430a
dni() deprecation test
RDaxini Nov 26, 2024
2aa0195
Merge remote-tracking branch 'upstream/main' into dni_clear
RDaxini Nov 26, 2024
e5d64a9
Update test_irradiance.py
RDaxini Nov 26, 2024
a7e9511
Update test_irradiance.py
RDaxini Nov 26, 2024
c4a5917
correct version number
RDaxini Nov 27, 2024
416a5d0
Update pvlib/tests/test_irradiance.py
RDaxini Nov 28, 2024
c24f6d5
remove warning from `complete_irradiance`
RDaxini Dec 3, 2024
e1dd203
test: remove return value checks
RDaxini Dec 3, 2024
5301eb9
add dirindex test
RDaxini Dec 3, 2024
953d980
fix test
RDaxini Dec 3, 2024
8273a29
linting
RDaxini Dec 3, 2024
ad556e1
Update v0.11.2.rst
RDaxini Dec 3, 2024
a1dbbb3
0.12->0.13 irradiance.py, test_irradiance.py
RDaxini Dec 4, 2024
a115f18
Apply suggestions from code review
RDaxini Dec 5, 2024
186dbe9
irradiance.py: +units, +version_changed directive
RDaxini Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
0.12->0.13 irradiance.py, test_irradiance.py
  • Loading branch information
@RDaxini
RDaxini committed Dec 4, 2024
commit a1dbbb32602d56ad88248bf63b0c484141ed88c1
4 changes: 2 additions & 2 deletions pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2155,7 +2155,7 @@ def _dirint_bins(times, kt_prime, zenith, w, delta_kt_prime):
since='0.11.2',
old_param_name='dni_clearsky',
new_param_name='dni_clear',
removal="0.12.0")
removal="0.13.0")
def dirindex(ghi, ghi_clearsky, dni_clear, zenith, times, pressure=101325.,
use_delta_kt_prime=True, temp_dew=None, min_cos_zenith=0.065,
max_zenith=87):
Expand Down Expand Up @@ -3620,7 +3620,7 @@ def _get_dirint_coeffs():
since='0.11.2',
old_param_name='clearsky_dni',
new_param_name='dni_clear',
removal="0.12.0")
removal="0.13.0")
def dni(ghi, dhi, zenith, dni_clear=None, clearsky_tolerance=1.1,
zenith_threshold_for_zero_dni=88.0,
zenith_threshold_for_clearsky_limit=80.0):
Expand Down
4 changes: 2 additions & 2 deletions pvlib/tests/test_irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ def test_dirindex_min_cos_zenith_max_zenith():
assert_series_equal(out, expected)


@fail_on_pvlib_version("0.12")
@fail_on_pvlib_version("0.13")
def test_dirindex_dni_clearsky_deprecation():
times = pd.DatetimeIndex(['2014-06-24T12-0700', '2014-06-24T18-0700'])
ghi = pd.Series([0, 1], index=times)
Expand Down Expand Up @@ -1157,7 +1157,7 @@ def test_dni():
146.190220008, 573.685662283]))


@fail_on_pvlib_version("0.12")
@fail_on_pvlib_version("0.13")
def test_dni_dni_clearsky_deprecation():
ghi = pd.Series([90, 100, 100, 100, 100])
dhi = pd.Series([100, 90, 50, 50, 50])
Expand Down
Loading
0