8000 [WIP] Adopt `ghi_clear` variable name for clearsky GHI by RDaxini · Pull Request #2273 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

[WIP] Adopt ghi_clear variable name for clearsky GHI #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

[WIP] Adopt ghi_clear variable name for clearsky GHI #2273

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
bf1c0d8
irradiance.py: ghi_from_poa() and clearsky_index()
RDaxini Oct 21, 2024
37d17b8
clearsky.py: haurwitz(), detect_clearsky
RDaxini Oct 21, 2024
9fa9fdc
clearsky.py: detect_clearsky
RDaxini Oct 21, 2024
00ffbd9
irradiance.py: dirindex()
RDaxini Oct 21, 2024
b21e1eb
modify tests
RDaxini Oct 25, 2024
57288e7
add deprecation warning
RDaxini Nov 21, 2024
00d7b70
Update clearsky.py
RDaxini Nov 25, 2024
6c78cb8
Merge remote-tracking branch 'upstream/main' into ghi_clear
RDaxini Nov 25, 2024
5b273df
fix unrelated linting issues
RDaxini Nov 25, 2024
38a409d
fix unrelated linting issue
RDaxini Nov 25, 2024
263ad4e
Update test_clearsky.py
RDaxini Nov 25, 2024
ba5ffaa
Revert "Update test_clearsky.py"
RDaxini Nov 25, 2024
f45cf19
Reapply "Update test_clearsky.py"
RDaxini Nov 25, 2024
d7a6f83
Revert "Update test_clearsky.py"
RDaxini Nov 25, 2024
fbd49e9
Revert "fix unrelated linting issue"
RDaxini Nov 25, 2024
84987b0
Revert "fix unrelated linting issues"
RDaxini Nov 25, 2024
1622571
Revert "Merge remote-tracking branch 'upstream/main' into ghi_clear"
RDaxini Nov 25, 2024
5879282
Revert "Update clearsky.py"
RDaxini Nov 25, 2024
bbe9d4f
Revert "add deprecation warning"
RDaxini Nov 25, 2024
aeab5cc
Revert "modify tests"
RDaxini Nov 25, 2024
9be20a6
Revert "irradiance.py: dirindex()"
RDaxini Nov 25, 2024
efdbbd8
Revert "clearsky.py: detect_clearsky"
RDaxini Nov 25, 2024
feab85c
Revert "clearsky.py: haurwitz(), detect_clearsky"
RDaxini Nov 25, 2024
c9c6900
Revert "irradiance.py: ghi_from_poa() and clearsky_index()"
RDaxini Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "modify tests" 
This reverts commit b21e1eb.
  • Loading branch information
@RDaxini
RDaxini committed Nov 25, 2024
commit aeab5cc8e9de31c3cf1fd4c2f751ae953292b389
14 changes: 7 additions & 7 deletions pvlib/tests/test_irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ def test_erbs_all_scalar():

def test_dirindex(times):
ghi = pd.Series([0, 0, 1038.62, 254.53], index=times)
ghi_clear = pd.Series(
ghi_clearsky = pd.Series(
np.array([0., 79.73860422, 1042.48031487, 257.20751138]),
index=times
)
Expand All @@ -1073,7 +1073,7 @@ def test_dirindex(times):
)
pressure = 93193.
tdew = 10.
out = irradiance.dirindex(ghi, ghi_clear, dni_clearsky,
out = irradiance.dirindex(ghi, ghi_clearsky, dni_clearsky,
zenith, times, pressure=pressure,
temp_dew=tdew)
dirint_close_values = irradiance.dirint(ghi, zenith, times,
Expand All @@ -1100,26 +1100,26 @@ def test_dirindex_min_cos_zenith_max_zenith():
# times don't have any physical relevance
times = pd.DatetimeIndex(['2014-06-24T12-0700', '2014-06-24T18-0700'])
ghi = pd.Series([0, 1], index=times)
ghi_clear = pd.Series([0, 1], index=times)
ghi_clearsky = pd.Series([0, 1], index=times)
dni_clearsky = pd.Series([0, 5], index=times)
solar_zenith = pd.Series([90, 89.99], index=times)

out = irradiance.dirindex(ghi, ghi_clear, dni_clearsky, solar_zenith,
out = irradiance.dirindex(ghi, ghi_clearsky, dni_clearsky, solar_zenith,
times)
expected = pd.Series([nan, nan], index=times)
assert_series_equal(out, expected)

out = irradiance.dirindex(ghi, ghi_clear, dni_clearsky, solar_zenith,
out = irradiance.dirindex(ghi, ghi_clearsky, dni_clearsky, solar_zenith,
times, min_cos_zenith=0)
expected = pd.Series([nan, nan], index=times)
assert_series_equal(out, expected)

out = irradiance.dirindex(ghi, ghi_clear, dni_clearsky, solar_zenith,
out = irradiance.dirindex(ghi, ghi_clearsky, dni_clearsky, solar_zenith,
times, max_zenith=90)
expected = pd.Series([nan, nan], index=times)
assert_series_equal(out, expected)

out = irradiance.dirindex(ghi, ghi_clear, dni_clearsky, solar_zenith,
out = irradiance.dirindex(ghi, ghi_clearsky, dni_clearsky, solar_zenith,
times, min_cos_zenith=0, max_zenith=100)
expected = pd.Series([nan, 5.], index=times)
assert_series_equal(out, expected)
Expand Down
0