8000 Top Ranking Issues by kurt-rhee · Pull Request #2267 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Top Ranking Issues #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 19, 2024
Merged

Top Ranking Issues #2267

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0bbfdc4
reset top ranking issues
kurt-rhee Oct 18, 2024
475a166
flake8 fixes
kurt-rhee Oct 18, 2024
66685b1
Create top-ranked-issues.yml
AdamRJensen Oct 19, 2024
0cc31a3
Update f-string formatting
AdamRJensen Oct 19, 2024
d4fccf8
Change Cron job to every 10 minutes
AdamRJensen Oct 19, 2024
a1ae0d5
Merge branch 'main' into main
AdamRJensen Oct 19, 2024
e453984
Add quotes to cron schedule
AdamRJensen Oct 19, 2024
322e659
excluding the overview card from the ranked list and changing token n…
kurt-rhee Oct 19, 2024
568ac34
changed back to GITHUB_ACCESS_TOKEN
kurt-rhee Oct 19, 2024
2ffc687
Update scripts/update_top_ranking_issues.py
kurt-rhee Oct 19, 2024
7f1d15a
added break condnition on generator
kurt-rhee Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update scripts/update_top_ranking_issues.py 
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
  • Loading branch information
@kurt-rhee @echedey-ls
kurt-rhee and echedey-ls authored Oct 19, 2024
commit 2ffc6875d34c60892449f1239ef7b38ba732ad4f
14 changes: 9 additions & 5 deletions scripts/update_top_ranking_issues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
repository: Repository = github.get_repo(repo_name)

# Number of top issues to list
MAX_ISSUES = 19

Check failure on line 27 in scripts/update_top_ranking_issues.py

View workflow job for this annotation

GitHub Actions / flake8-linter 

F841 local variable 'MAX_ISSUES' is assigned to but never used
TOP_ISSUES_CARD_NUMBER = 2196

# Rate limiting
Expand All @@ -40,18 +40,22 @@

# Format markdown
ranked_issues = []
for (i, issue) in zip(range(MAX_ISSUES), issues):

# Don't include the overview card
# Continuous number generator for the numbered list, starts at 1
index_generator = itertools.count(1)

Check failure on line 44 in scripts/update_top_ranking_issues.py

View workflow job for this annotation

GitHub Actions / flake8-linter 

F821 undefined name 'itertools'
for issue in issues:
# 7349 Don't include the overview card (skip to next iteration)
if issue.number == TOP_ISSUES_CARD_NUMBER:
pass
continue

# Get numbered list item index from generator
i = next(index_generator)

markdown_bullet_point: str = (
f"{issue.html_url} " +
f"({issue._rawData['reactions']['+1']} :thumbsup:)"
)

markdown_bullet_point = f"{i + 1}. {markdown_bullet_point}"
markdown_bullet_point = f"{i}. {markdown_bullet_point}"
ranked_issues.append(markdown_bullet_point)

# edit top issues
Expand Down
Loading
0