Replace freq '1M' with '1MS' #2266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up removing the Note, test failures are unrelated. |
AdamRJensen
commented
Mar 14, 2025
|
Closed in favor of #2473. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The
freq='1M'is used in a couple of places in the pvlib iotools functions, which results in the following future warning:The frequency 'M' is being phased out in favor of 'ME' and 'MS' which correspond to month end and month start. 'M' is equivalent to 'ME'. However, 'MS' is the only one supported in our minimum Pandas version, whereas 'ME' was first introduced in a later version. For the iotools functions, I think 'MS' is conceptually more correct.
Minimum changes to the lookup linked turbidity functions were made to make tests pass. I preferred making these modifications over calculating new test values.