10000 changed wid to omega_ideal by kurt-rhee · Pull Request #2143 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

changed wid to omega_ideal #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

changed wid to omega_ideal #2143

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37dcc54
changed wid to omega_ideal
kurt-rhee Jul 22, 2024
00e193a
- fixed flake8 concerts
kurt-rhee Jul 22, 2024
f9e3636
additional flake8 lints
kurt-rhee Jul 22, 2024
2c09f02
Revert "Remove warnings in docs (#2128)"
kurt-rhee Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
changed wid to omega_ideal
  • Loading branch information
@kurt-rhee
kurt-rhee committed Jul 22, 2024
commit 37dcc54c0d6db77d4e78a49e79255e30da4ce8e7
18 changes: 10 additions & 8 deletions pvlib/tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,17 @@
if apparent_azimuth.ndim > 1 or apparent_zenith.ndim > 1:
raise ValueError('Input dimensions must not exceed 1')

# The ideal tracking angle wid is the rotation to place the sun position
# The ideal tracking angle omega_ideal is the rotation to place the sun position

Check failure on line 130 in pvlib/tracking.py

View workflow job for this annotation

GitHub Actions / flake8-linter 

E501 line too long (84 > 79 characters)
# vector (xp, yp, zp) in the (x, z) plane, which is normal to the panel and
# contains the axis of rotation. wid = 0 indicates that the panel is
# contains the axis of rotation. omega_id = 0 indicates that the panel is
# horizontal. Here, our convention is that a clockwise rotation is
# positive, to view rotation angles in the same frame of reference as
# azimuth. For example, for a system with tracking axis oriented south, a
# rotation toward the east is negative, and a rotation to the west is
# positive. This is a right-handed rotation around the tracker y-axis.
wid = shading.projected_solar_zenith_angle(
# Omega_ideal is the plaintext representation of the ideal tracking
# angle from Lorenzo et al 2011. https://doi.org/10.1002/pip.1085
omega_ideal = shading.projected_solar_zenith_angle(
axis_tilt=axis_tilt,
axis_azimuth=axis_azimuth,
solar_zenith=apparent_zenith,
Expand All @@ -144,7 +146,7 @@

# filter for sun above panel horizon
zen_gt_90 = apparent_zenith > 90
wid[zen_gt_90] = np.nan
omega_ideal[zen_gt_90] = np.nan

# Account for backtracking
if backtrack:
Expand All @@ -153,19 +155,19 @@
axes_distance = 1/(gcr * cosd(cross_axis_tilt))

# NOTE: account for rare angles below array, see GH 824
temp = np.abs(axes_distance * cosd(wid - cross_axis_tilt))
temp = np.abs(axes_distance * cosd(omega_ideal - cross_axis_tilt))

# backtrack angle using [1], Eq. 14
with np.errstate(invalid='ignore'):
wc = np.degrees(-np.sign(wid)*np.arccos(temp))
wc = np.degrees(-np.sign(omega_ideal)*np.arccos(temp))

# NOTE: in the middle of the day, arccos(temp) is out of range because
# there's no row-to-row shade to avoid, & backtracking is unnecessary
# [1], Eqs. 15-16
with np.errstate(invalid='ignore'):
tracker_theta = wid + np.where(temp < 1, wc, 0)
tracker_theta = omega_ideal + np.where(temp < 1, wc, 0)
else:
tracker_theta = wid
tracker_theta = omega_ideal

# NOTE: max_angle defined relative to zero-point rotation, not the
# system-plane normal
Expand Down
Loading
0