8000 Add method to fit Huld model by cwhanse · Pull Request #1979 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Add method to fit Huld model #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add method to fit Huld model #1979

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
55c9530
add fit_huld
cwhanse Feb 23, 2024
119b0b8
docs
cwhanse Feb 23, 2024
007cb40
Update v0.10.4.rst
cwhanse Feb 23, 2024
52c0d42
formatting, mark for scipy
cwhanse Feb 23, 2024
0c68e78
adjust import, add docstring
cwhanse Feb 23, 2024
082a545
Merge branch 'main' of https://github.com/pvlib/pvlib-python into fit…
cwhanse Mar 26, 2024
8a80853
Merge branch 'main' of https://github.com/pvlib/pvlib-python into fit…
cwhanse Apr 4, 2024
7197b8a
handle NaN, add note about regression method, use temp_module
cwhanse Apr 4, 2024
c24b7cc
forgot to save
cwhanse Apr 4, 2024
1250bcd
lint
cwhanse Apr 4, 2024
d854d0f
Merge branch 'main' of https://github.com/pvlib/pvlib-python into fit…
cwhanse Apr 18, 2024
464749e
respond to comments
cwhanse Apr 18, 2024
e0e637e
put v0.10.4.rst back
cwhanse Apr 18, 2024
d42ca26
Merge branch 'main' of https://github.com/pvlib/pvlib-python into fit…
cwhanse May 31, 2024
1305f6e
move to v0.11.0
cwhanse May 31, 2024
e1873fc
restore v0.10.5 whatsnew
cwhanse May 31, 2024
6437c14
Update v0.11.0.rst
cwhanse May 31, 2024
9b9fbe5
Merge branch 'main' into fit_huld
cwhanse Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@cwhanse
cwhanse committed Apr 4, 2024
commit 1250bcd01f54276f14be1ae04f2864f6373f8c9b
4 changes: 2 additions & 2 deletions pvlib/pvarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,9 +437,9 @@ def fit_huld(effective_irradiance, temp_module, pdc, method='ols'):
tprime*logGprime**2, tprime**2), axis=0).T
X = sm.add_constant(X)

if method=='ols':
if method == 'ols':
model = sm.OLS(Y, X, missing='drop')
elif method=='robust':
elif method == 'robust':
model = sm.RLM(Y, X, missing='drop')
else:
raise ValueError("method must be ols or robust")
Expand Down
2 changes: 1 addition & 1 deletion pvlib/tests/test_pvarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,6 @@ def test_fit_huld_method_error():
ee, tc = pvarray._build_iec61853()
pdc0 = 250
pdc = pvarray.huld(ee, tc, pdc0, cell_type='csi')
method='brute_force'
method = 'brute_force'
with pytest.raises(ValueError, match="method must be ols or robust"):
m_pdc0, k = pvarray.fit_huld(ee, tc, pdc, method=method)
0