Projected zenith convenience function #1904
Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -234,7 +234,7 @@ def sky_diffuse_passias(masking_angle): | |
| return 1 - cosd(masking_angle/2)**2 | ||
|
|
||
|
|
||
| def projected_solar_zenith_angle(axis_tilt, axis_azimuth, | ||
| solar_apparent_elevation, solar_azimuth): | ||
| r""" | ||
| Calculate projected solar zenith angle in degrees. | ||
|
|
@@ -243,9 +243,9 @@ def projected_solar_zenith_angle(surface_tilt, surface_azimuth, | |
|
|
||
| Parameters | ||
| ---------- | ||
| axis_tilt : numeric | ||
|
There was a problem hiding this comment. For a general purpose function, would There was a problem hiding this comment. There's a comment up there from @kandersolar asking for changes from I'll request reviews for the current reviewers hoping they also give some insight regarding this. Anyway, if you are sure of it, I change it without no problems. There was a problem hiding this comment. Is the issue that I'm inclined (pun intended) to keep the term Perhaps a good compromise is to clarify that point in the parameter description/Notes? There was a problem hiding this comment. I feel like these two terms refer to pure maths, and mapping those words to concise real-world systems is a bit counter-productive due to the variability. Is there some generic -maths- term we can use for a general description of this, a projection? Like Just to weight in some more options outside of the current frame:
I don't dislike this possibility if we don't agree on anything else eventually, but we are overcomplicating the docs IMHO. BTW, I'm +1 for the There was a problem hiding this comment. I admit to suffering from tunnel vision for trackers, but in my view How about: Similar for |
||
| Axis tilt angle in degrees. From horizontal plane to array plane. | ||
| axis_azimuth : numeric | ||
| Axis azimuth angle in degrees. | ||
| North = 0°; East = 90°; South = 180°; West = 270° | ||
| solar_apparent_elevation : numeric | ||
|
|
@@ -274,21 +274,21 @@ def projected_solar_zenith_angle(surface_tilt, surface_azimuth, | |
| """ | ||
| # Avoid recalculating these values | ||
| cosd_solar_apparent_elevation = cosd(solar_apparent_elevation) | ||
| cosd_axis_azimuth = cosd(axis_azimuth) | ||
| sind_axis_azimuth = sind(axis_azimuth) | ||
| sind_axis_tilt = sind(axis_tilt) | ||
|
|
||
| # Notation from [1] | ||
| # Sun's x, y, z coords | ||
| sx = cosd_solar_apparent_elevation * sind(solar_azimuth) | ||
| sy = cosd_solar_apparent_elevation * cosd(solar_azimuth) | ||
| sz = sind(solar_apparent_elevation) | ||
| # Eq. (4); sx', sz' values from sun coordinates projected onto surface | ||
| sx_prime = sx * cosd_axis_azimuth - sy * sind_axis_azimuth | ||
| sz_prime = ( | ||
| sx * sind_axis_azimuth * sind_axis_tilt | ||
| + sy * sind_axis_tilt * cosd_axis_azimuth | ||
| + sz * cosd(axis_tilt) | ||
| ) | ||
| # Eq. (5); angle between sun's beam and surface | ||
| theta_T = np.degrees(np.arctan2(sx_prime, sz_prime)) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.