8000 Add get_srml iotools function; deprecate read_srml_month_from_solardat by AdamRJensen · Pull Request #1779 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Add get_srml iotools function; deprecate read_srml_month_from_solardat #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 29, 2023
Merged

Add get_srml iotools function; deprecate read_srml_month_from_solardat #1779

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f4e8248
Initial commit
AdamRJensen Jun 19, 2023
15f6d4c
Merge remote-tracking branch 'upstream/main' into get_srml
AdamRJensen Jun 19, 2023
0f83b2e
Add exception for non-existing file names
AdamRJensen Jun 19, 2023
8f14cb8
Update error handling
AdamRJensen Jun 19, 2023
b09144f
Deprecate read_srml_month_from_solardat
AdamRJensen Jun 19, 2023
7057ede
Add fail_on_pvlib_version to tests
AdamRJensen Jun 19, 2023
2b5c39b
Apply suggestions from code review
AdamRJensen Jun 21, 2023
d689a14
Address code review
AdamRJensen Jun 21, 2023
e85ddf7
Conform to code review
AdamRJensen Jun 25, 2023
48b6310
Merge branch 'main' into get_srml_v2
AdamRJensen Jun 25, 2023
a308cda
Add warning message
AdamRJensen Jun 28, 2023
1830b03
Use assert_frame_equal
AdamRJensen Jun 28, 2023
a1b3922
Update pvlib/tests/iotools/test_srml.py
AdamRJensen Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update pvlib/tests/iotools/test_srml.py 
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
  • Loading branch information
@AdamRJensen @kandersolar
AdamRJensen and kandersolar authored Jun 29, 2023
commit a1b39226827a840596d8a33abc1fad5424df3c43
2 changes: 1 addition & 1 deletion pvlib/tests/iotools/test_srml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def test_get_srml():
file_data = srml.read_srml(url)
requested, _ = srml.get_srml(station='EU', start='2018-01-01',
end='2018-01-31')
assert assert_frame_equal(file_data, requested)
assert_frame_equal(file_data, requested)


@fail_on_pvlib_version('0.11')
Expand Down
0