8000 Deprecate `pvsystem.singlediode` parameter `ivcurve_pnts` by reepoi · Pull Request #1743 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Deprecate pvsystem.singlediode parameter ivcurve_pnts #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kandersolar merged 9 commits into from
Jun 23, 2023
Merged

Deprecate pvsystem.singlediode parameter ivcurve_pnts #1743

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4a1dfab
deprecating pvsystem.singlediode ivcurve_pnts parameter
reepoi May 23, 2023
4b6c011
lowercase v in i_xx description
reepoi May 23, 2023
e5365fa
Merge branch 'main' of github.com:pvlib/pvlib-python into singlediode…
reepoi May 24, 2023
b21640b
update whatsnew
reepoi May 24, 2023
3f69340
Update docs/examples/iv-modeling/plot_singlediode.py
reepoi Jun 7, 2023
7fafac1
add singlediode ivcurve_pnts deprecation warning test
reepoi Jun 7, 2023
8000 54457f4
add pytest.warns where pvsystem.singlediode ivcurve_pnts is used in t…
reepoi Jun 13, 2023
0e7ee1b
update sde, sdm tests to use pvsystem.i_from_v
reepoi Jun 13, 2023
a5570a1
Update pvlib/tests/test_pvsystem.py
reepoi Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update pvlib/tests/test_pvsystem.py 
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
  • Loading branch information
@reepoi @kandersolar
reepoi and kandersolar authored Jun 13, 2023
commit a5570a160fcdc46c5e8bfcdbbcce1ce43d68dc00
1 change: 1 addition & 0 deletions pvlib/tests/test_pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,6 +1429,7 @@ def test_singlediode_series_ivcurve(cec_module_params):
assert_allclose(v, expected[k], atol=1e-6)


@fail_on_pvlib_version('0.11')
@pytest.mark.parametrize('method', ['lambertw', 'brentq', 'newton'])
def test_singlediode_ivcurvepnts_deprecation_warning(method):
with pytest.warns(pvlibDeprecationWarning, match='ivcurve_pnts'):
Expand Down
0