8000 Vectorize `pvlib.bifacial.utils._vf_ground_sky_2d` across `surface_tilt` by kandersolar · Pull Request #1682 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Vectorize pvlib.bifacial.utils._vf_ground_sky_2d across surface_tilt #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 18, 2023
+117 −68
Merged

Vectorize pvlib.bifacial.utils._vf_ground_sky_2d across surface_tilt #1682

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9c5bc1c
vectorize _vf_ground_sky_2d across surface_tilt
kandersolar Mar 2, 2023
af68f84
whatsnew
kandersolar Mar 3, 2023
e5bdf5a
remove straggler instrumentation
kandersolar Mar 3, 2023
fb1d943
docstring improvement
kandersolar Mar 3, 2023
bb82373
stickler
kandersolar Mar 3, 2023
ee421a4
update failing test
kandersolar Mar 3, 2023
0d80d7d
remove "per-point" language
kandersolar Mar 3, 2023
9bf9360
sprinkle in some `del`s
kandersolar Mar 8, 2023
0bc1087
contorted version using numpy's `out` parameter
kandersolar Mar 8, 2023
6f490ea
even more out
kandersolar Mar 8, 2023
79b4849
add vectorize kwarg to infinite_sheds
kandersolar Mar 9, 2023
3d3eef0
benchmark both vectorize=True and vectorize=False
kandersolar Mar 9, 2023
8445aa5
improve comments
kandersolar Mar 9, 2023
3f46b6a
test coverage
kandersolar Mar 9, 2023
d53197b
stickler
kandersolar Mar 9, 2023
134f0b6
Merge branch 'main' into vectorize_vf_ground_sk_2d
kandersolar Mar 9, 2023
a5acbc0
Merge branch 'main' into vectorize_vf_ground_sk_2d
kandersolar Mar 15, 2023
63f6675
Apply suggestions from code review
kandersolar Mar 15, 2023
514a1e9
stickler
kandersolar Mar 15, 2023
bffda3e
Merge branch 'main' into vectorize_vf_ground_sk_2d
kandersolar Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
  • Loading branch information
@kandersolar @cwhanse
kandersolar and cwhanse authored Mar 15, 2023
commit 63f6675d3d4cfcf9210224c2612a5aa8c885ba79
6 changes: 3 additions & 3 deletions pvlib/bifacial/infinite_sheds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
def _vf_ground_sky_integ(surface_tilt, surface_azimuth, gcr, height,
pitch, max_rows=10, npoints=100, vectorize=False):
"""
Integrated view factor from the ground to the sky underneath
Integrated view factor to the sky from the ground underneath
interior rows of the array.

Parameters
Expand Down Expand Up @@ -469,7 +469,7 @@ def get_irradiance_poa(surface_tilt, surface_azimuth, solar_zenith,
on the surface that is not reflected away. [unitless]

npoints : int, default 100
Number of discretization points for calculating integrated viewfactors.
Number of discretization points for calculating integrated view factors.

vectorize : bool, default False
If True, vectorize the view factor calculation across ``surface_tilt``.
Expand Down Expand Up @@ -706,7 +706,7 @@ def get_irradiance(surface_tilt, surface_azimuth, solar_zenith, solar_azimuth,
etc. A negative value is a reduction in back irradiance. [unitless]

npoints : int, default 100
Number of discretization points for calculating integrated viewfactors.
Number of discretization points for calculating integrated view factors.

vectorize : bool, default False
If True, vectorize the view factor calculation across ``surface_tilt``.
Expand Down
0