8000 WIP: Speed up singlediode._lambertw by cwhanse · Pull Request #1661 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

WIP: Speed up singlediode._lambertw #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

WIP: Speed up singlediode._lambertw #1661

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c294e40
switch lambertw mpp to newton technique
cwhanse Feb 13, 2023
62a8996
handle Rsh=inf
cwhanse Feb 13, 2023
a97b383
document edits
cwhanse Feb 13, 2023
d84c83c
pacify stickler
cwhanse Feb 13, 2023
e6d0a33
doc fixes
cwhanse Feb 13, 2023
e1aff50
whatsnew
cwhanse Feb 13, 2023
d362d7b
add a benchmark
cwhanse Feb 13, 2023
063abf8
stickler, doc edits
cwhanse Feb 13, 2023
5a0c80b
revert to numpy 1.16
cwhanse Feb 14, 2023
9e88b91
rename benchmark functions
cwhanse Feb 14, 2023
91ecf1c
more doc edits
cwhanse Feb 14, 2023
6098885
fix stuff
cwhanse Feb 14, 2023
0ca692c
fix errors
cwhanse Feb 14, 2023
4da7d2f
Apply suggestions from code review
cwhanse Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pacify stickler
  • Loading branch information
@cwhanse
cwhanse committed Feb 13, 2023
commit d84c83c3c73f481348699912f5d5f21d6daece45
7 changes: 5 additions & 2 deletions pvlib/singlediode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ def _split_on_gsh(gsh):
idx_z = 0. == gsh
return idx_p, idx_z


def _imp_zero(i, il, io, rs, gsh, a):
''' Root of this function is at imp
'''
Expand All @@ -763,6 +763,8 @@ def _imp_zero(i, il, io, rs, gsh, a):


def _imp_zero_prime(i, il, io, rs, gsh, a):
''' Derivative of _imp_zero with respect to current i
'''
idx_p, idx_z = _split_on_gsh(gsh)
res = np.full_like(i, np.nan, dtype=np.float64)
if np.any(idx_z):
Expand All @@ -771,7 +773,8 @@ def _imp_zero_prime(i, il, io, rs, gsh, a):
res[idx_z] = 2. / t + i[idx_z] / t**2.
Copy link
Member
@kandersolar kandersolar Feb 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on whether my previous comment regarding a missing term is in error, this may also need an additional term

if np.any(idx_p):
wma = _w_psi(i[idx_p], il[idx_p], io[idx_p], gsh[idx_p], a[idx_p])
f = (il[idx_p] + io[idx_p] - i[idx_p]) / gsh[idx_p] - i[idx_p] * rs[idx_p] - a[idx_p] * wma
f = (il[idx_p] + io[idx_p] - i[idx_p]) / gsh[idx_p] - \
i[idx_p] * rs[idx_p] - a[idx_p] * wma
fprime = -rs[idx_p] - 1. / (gsh[idx_p] * (1. + wma))
fprime2 = -1. / (gsh[idx_p]**2. * a[idx_p]) * wma / (1 + wma)**3.
res[idx_p] = f / fprime**2. * fprime2 - 2.
Expand Down
0