8000 add support for zero gcr in bifacial.infinite_sheds and shading.masking_angle by kdebrab · Pull Request #1589 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

add support for zero gcr in bifacial.infinite_sheds and shading.masking_angle #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2022
Merged

add support for zero gcr in bifacial.infinite_sheds and shading.masking_angle #1589

merged 3 commits into from
Nov 11, 2022

Conversation

kdebrab
Copy link
Contributor
@kdebrab kdebrab commented Nov 11, 2022 •
edited by cwhanse
Loading
  • Closes ZeroDivisionError when gcr is zero #1576
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@cwhanse cwhanse added this to the 0.9.4 milestone Nov 11, 2022
cwhanse
cwhanse approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member
@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdebrab

@kandersolar kandersolar changed the title add support for zero gcr add support for zero gcr in bifacial.infinite_sheds and shading.masking_angle Nov 11, 2022
kandersolar
kandersolar approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member
@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kandersolar kandersolar merged commit eefc35c into pvlib:main Nov 11, 2022
@kdebrab kdebrab deleted the gcr_zero branch November 12, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhanse cwhanse cwhanse approved these changes

@kandersolar kandersolar kandersolar approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.9.4
44B4
Development

Successfully merging this pull request may close these issues.

ZeroDivisionError when gcr is zero
3 participants
@kdebrab @cwhanse @kandersolar
0