8000 Fix assertion in test_irradiance.py::test_get_ground_diffuse_albedo_0 by bowie2211 · Pull Request #1575 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Fix assertion in test_irradiance.py::test_get_ground_diffuse_albedo_0 #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2022
Merged

Fix assertion in test_irradiance.py::test_get_ground_diffuse_albedo_0 #1575

merged 2 commits into from
Oct 21, 2022

Conversation

bowie2211
Copy link
Contributor
@bowie2211 bowie2211 commented Oct 20, 2022 •
edited
Loading

…rtion is incorrect #1569

@kandersolar kandersolar added this to the 0.9.4 milestone Oct 20, 2022
@kandersolar
Copy link
Member
kandersolar commented Oct 20, 2022 •
edited
Loading

Thanks for the PR @bowie2211! Can you add a note to the v0.9.4 what's new file: /docs/sphinx/source/whatsnew/v0.9.4.rst. Something like this under the Testing header:

* Corrected a flawed test for :py:func:`~pvlib.irradiance.get_ground_diffuse` (:issue:`1569`, :pull:`1575`)

And add yourself to the Contributors list at the bottom of the file. Thanks!

kandersolar
kandersolar approved these changes Oct 21, 2022
View reviewed changes
< 8000 svg aria-label="Show options" role="img" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-kebab-horizontal"> Copy link
Member
@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bowie2211!

@kandersolar kandersolar changed the title Fixed test_irradiance.py::test_get_ground_diffuse_albedo_0 test asse… Fix assertion in test_irradiance.py::test_get_ground_diffuse_albedo_0 Oct 21, 2022
@kandersolar kandersolar merged commit b7768b4 into pvlib:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandersolar kandersolar kandersolar approved these changes

Assignees
No one assigned
Labels
bug testing
Projects
None yet
Milestone
0.9.4
Development

Successfully merging this pull request may close these issues.

test_irradiance.py::test_get_ground_diffuse_albedo_0 test assertion is incorrect
2 participants
@bowie2211 @kandersolar
0