8000 Add optional `return_components` parameter to irradiance.haydavies by spaneja · Pull Request #1568 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Add optional return_components parameter to irradiance.haydavies #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 31, 2022
Merged

Add optional return_components parameter to irradiance.haydavies #1568

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c33c1d4
haydavies_return_components
spaneja Oct 10, 2022
016709a
updating_return_components
spaneja Oct 11, 2022
b175954
stickler_stickler
spaneja Oct 11, 2022
6262b97
testing_update
spaneja Oct 11, 2022
a6ec0a1
docstring update
spaneja Oct 11, 2022
ad35a29
cleaning_updates
spaneja Oct 11, 2022
6c8d66a
testing_updates
spaneja Oct 12, 2022
750d51a
Merge branch 'master' into haydavis_return_components
kandersolar Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testing_update 
adding in test for when pandas is not being used.
  • Loading branch information
@spaneja
spaneja committed Oct 11, 2022
commit 6262b976d390ef31b7a6c15c975480ac1f1fabed
6 changes: 6 additions & 0 deletions pvlib/tests/test_irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,10 @@ def test_haydavies_components(irrad_data, ephem_data, dni_et):
40, 180, irrad_data['dhi'], irrad_data['dni'], dni_et,
ephem_data['apparent_zenith'], ephem_data['azimuth'],
return_components=True)
result_val = irradiance.haydavies(
40, 180, irrad_data['dhi'].values, irrad_data['dni'].values, dni_et,
ephem_data['apparent_zenith'].values, ephem_data['azimuth'].values,
return_components=True)
expected = pd.DataFrame(np.array(
[[0, 27.1775, 102.9949, 33.1909],
[0, 27.1775, 30.1818, 27.9837],
Expand All @@ -229,6 +233,8 @@ def test_haydavies_components(irrad_data, ephem_data, dni_et):
assert_allclose(result.horizon, [0, 0, 0, 0], atol=1e-4)
assert_frame_equal(result, expected, check_less_precise=4)
assert isinstance(result, pd.DataFrame)
assert_allclose(result_val['sky_diffuse'], [0, 27.1775, 102.9949, 33.1909],
atol=1e-4)


def test_reindl(irrad_data, ephem_data, dni_et):
Expand Down
0