8000 Make leap_day=True default for PSM3 (deprecation) by AdamRJensen · Pull Request #1511 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Make leap_day=True default for PSM3 (deprecation) #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Make leap_day=True default for PSM3 (deprecation) #1511

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62aae52
Add deprecation for leap_day
AdamRJensen Aug 1, 2022
5a755fc
Add test coverage
AdamRJensen Aug 1, 2022
e14406f
Do not raise warning for TMY requests
AdamRJensen Aug 2, 2022
adb8a1e
Replace & by and, and update whatsnew
AdamRJensen Aug 3, 2022
3c42c7b
Update whatsnew
AdamRJensen Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test coverage
  • Loading branch information
@AdamRJensen
AdamRJensen committed Aug 1, 2022
commit 5a755fc3dc7cc08abf99621cd0b7112cd17fd27f
23 changes: 18 additions & 5 deletions pvlib/tests/iotools/test_psm3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def test_get_psm3_tmy(nrel_api_key):
"""test get_psm3 with a TMY"""
data, metadata = psm3.get_psm3(LATITUDE, LONGITUDE, nrel_api_key,
PVLIB_EMAIL, names='tmy-2017',
map_variables=False)
leap_day=False, map_variables=False)
expected = pd.read_csv(TMY_TEST_DATA)
assert_psm3_equal(data, metadata, expected)

Expand All @@ -89,7 +89,8 @@ def test_get_psm3_singleyear(nrel_api_key):
"""test get_psm3 with a single year"""
data, metadata = psm3.get_psm3(LATITUDE, LONGITUDE, nrel_api_key,
PVLIB_EMAIL, names='2017',
map_variables=False, interval=30)
leap_day=False, map_variables=False,
interval=30)
expected = pd.read_csv(YEAR_TEST_DATA)
assert_psm3_equal(data, metadata, expected)

Expand All @@ -100,7 +101,7 @@ def test_get_psm3_5min(nrel_api_key):
"""test get_psm3 for 5-minute data"""
data, metadata = psm3.get_psm3(LATITUDE, LONGITUDE, nrel_api_key,
PVLIB_EMAIL, names='2019', interval=5,
map_variables=False)
leap_day=False, map_variables=False)
assert len(data) == 525600/5
first_day = data.loc['2019-01-01']
expected = pd.read_csv(YEAR_TEST_DATA_5MIN)
Expand Down Expand Up @@ -137,7 +138,8 @@ def test_get_psm3_tmy_errors(
"""
with pytest.raises(HTTPError) as excinfo:
psm3.get_psm3(latitude, longitude, api_key, PVLIB_EMAIL,
names=names, interval=interval, map_variables=False)
names=names, interval=interval, leap_day=False,
map_variables=False)
# ensure the HTTPError caught isn't due to overuse of the API key
assert "OVER_RATE_LIMIT" not in str(excinfo.value)

Expand Down Expand Up @@ -186,7 +188,7 @@ def test_get_psm3_attribute_mapping(nrel_api_key):
data, meta = psm3.get_psm3(LATITUDE, LONGITUDE, nrel_api_key, PVLIB_EMAIL,
names=2019, interval=60,
attributes=['ghi', 'wind_speed'],
map_variables=True)
leap_day=False, map_variables=True)
assert 'ghi' in data.columns
assert 'wind_speed' in data.columns
assert 'latitude' in meta.keys()
Expand All @@ -199,3 +201,14 @@ def test_get_psm3_attribute_mapping(nrel_api_key):
def test_psm3_variable_map_deprecation_warning(nrel_api_key):
with pytest.warns(pvlibDeprecationWarning, match='names will be renamed'):
_ = psm3.read_psm3(MANUAL_TEST_DATA)


@pytest.mark.remote_data
@pytest.mark.flaky(reruns=RERUNS, reruns_delay=RERUNS_DELAY)
def test_psm3_leap_day_deprecation_warning(nrel_api_key):
with pytest.warns(pvlibDeprecationWarning,
match='default to leap_day=True'):
_, _ = psm3.get_psm3(LATITUDE, LONGITUDE, nrel_api_key, PVLIB_EMAIL,
names=2019, interval=60,
attributes=['ghi', 'wind_speed'],
map_variables=True)
0