8000 Accept albedo in weather input to ModelChain.run_model method by cwhanse · Pull Request #1478 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Accept albedo in weather input to ModelChain.run_model method #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Aug 19, 2022
Merged

Accept albedo in weather input to ModelChain.run_model method #1478

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
d0c52b6
permit albedo to be a Series
cwhanse Jun 9, 2022
e64a940
work on modelchain
cwhanse Jun 10, 2022
de34639
Merge branch 'master' of https://github.com/pvlib/pvlib-python into a…
cwhanse Jun 13, 2022
0fa45e8
fix tests
cwhanse Jun 13, 2022
cdf853e
shh stickler, docstrings
cwhanse Jun 13, 2022
b3ee156
improve coverage
cwhanse Jun 13, 2022
9e1ce0e
improve coverage correctly
cwhanse Jun 13, 2022
59a37da
finalize coverage, stickler
cwhanse Jun 13, 2022
0295dd0
whatsnew
cwhanse Jun 13, 2022
b9a7308
from review
cwhanse Jun 13, 2022
e518996
Merge branch 'master' of https://github.com/pvlib/pvlib-python into a…
cwhanse Jun 20, 2022
e4c5fa5
don't mutate inputs
cwhanse Jun 20, 2022
acb3657
get_irradiance in tracking.py
cwhanse Jun 20, 2022
2bd97b8
shh stickler
cwhanse Jun 20, 2022
5f0d455
shh stickler
cwhanse Jun 20, 2022
0a10e56
improvements from review
cwhanse Jun 21, 2022
122e992
Merge branch 'pvlib:master' into albedo
cwhanse Jun 21, 2022
cbe2099
update whatsnew
cwhanse Jun 21, 2022
15ff086
Merge branch 'master' of https://github.com/pvlib/pvlib-python into a…
cwhanse Jun 21, 2022
d787675
Merge branch 'albedo' of https://github.com/cwhanse/pvlib-python into…
cwhanse Jun 21, 2022
18a4ed1
Apply suggestions from code review
cwhanse Jun 23, 2022
e2e9f5e
docstring improvements
cwhanse Jun 23, 2022
18bb4d5
Merge branch 'master' into albedo
cwhanse Jul 22, 2022
0bde3c7
Apply suggestions from code review
cwhanse Jul 30, 2022
2ea9c97
Update pvlib/tests/test_irradiance.py
cwhanse Jul 30, 2022
ab2c11a
from review
cwhanse Jul 30, 2022
4340bb0
one more
cwhanse Jul 30, 2022
6193147
more use of fixture, add Array.get_irradiance test
cwhanse Aug 1, 2022
0ecfb7d
more decimal places
cwhanse Aug 1, 2022
af6ff0e
spacing
cwhanse Aug 10, 2022
100a8a1
line length
cwhanse Aug 17, 2022
1a835b1
write albedo from system.arrays to ModelChainResult
cwhanse Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
one more
  • Loading branch information
@cwhanse
cwhanse committed Jul 30, 2022
commit 4340bb0ac7a3d4491b1b799edc3929ebfb764998
4 changes: 2 additions & 2 deletions pvlib/tests/test_modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,11 +508,11 @@ def test_prepare_inputs_albedo_in_weather(
# weather as a single DataFrame
mc.prepare_inputs(weather)
num_arrays = sapm_dc_snl_ac_system_Array.num_arrays
assert len(mc.results.total_irrad) == num_arrays
assert len(mc.results.albedo) == num_arrays
# repeat with tuple of weather
mc.prepare_inputs(input_type((weather, weather)))
num_ar 4CF7 rays = sapm_dc_snl_ac_system_Array.num_arrays
assert len(mc.results.total_irrad) == num_arrays
assert len(mc.results.albedo) == num_arrays


def test_prepare_inputs_no_irradiance(sapm_dc_snl_ac_system, location):
Expand Down
0