8000 Townsend snow (building on #1251) by reepoi · Pull Request #1468 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Townsend snow (building on #1251) #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Sep 12, 2022
Merged

Townsend snow (building on #1251) #1468

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0b736d4
first experimental commit
Jun 25, 2021
3f2c40d
Added numpy array support
Jul 2, 2021
974d516
changed var names
Jul 16, 2021
655fa79
changed townsend_Se to private
Jul 20, 2021
c0c8b4d
removed snow.loss_townsend in api.rst
abhisheksparikh Mar 17, 2022
f0e1f3a
Merge branch 'master' of https://github.com/abhisheksparikh/pvlib-pyt…
abhisheksparikh Mar 17, 2022
78716f7
added loss_townsend description in effects_on_pv_system_output.rst
abhisheksparikh Mar 17, 2022
5e06a40
fixed stickler checks
abhisheksparikh Mar 17, 2022
a5c5315
removed rounding of loss and changed to 0-1 range
abhisheksparikh Mar 18, 2022
f79e906
Merge branch 'master' into townsend_snow
abhisheksparikh Mar 18, 2022
f7ba1ad
Merge branch 'master' of https://github.com/pvlib/pvlib-python into t…
reepoi May 26, 2022
c2d6d4f
implementing changes suggested in PR #1251
reepoi May 26, 2022
68c85f7
removing new line
reepoi May 26, 2022
e5118ef
removing new line
reepoi May 26, 2022
c253f59
remove new line
reepoi Jun 7, 2022
e2c1f76
Se to effective_snow
reepoi Jun 7, 2022
4783556
adding PR number to whatsnew
reepoi Jun 7, 2022
588115e
address stickler line too long
reepoi Jun 7, 2022
36ae264
remove links and noqa E501, and fix long lines
reepoi Jun 13, 2022
d9dad34
converting to metric system
reepoi Jun 13, 2022
1d5eb88
poa_global from kWh/m2 to Wh/m2
reepoi Jun 13, 2022
bbe5bc3
changing returned loss from kWh to Wh
reepoi Jun 13, 2022
b3ab5aa
fixing capacity loss calculation units to keep correct C1 value
reepoi Jun 14, 2022
cff9345
Merge branch 'master' into townsend_snow_loss
reepoi Jun 16, 2022
b759bcf
convert relative humidity from percent to fraction
reepoi Jun 20, 2022
febe4a2
Merge branch 'townsend_snow_loss' of https://github.com/reepoi/pvlib-…
reepoi Jun 20, 2022
f46fc00
neatening docstrings and adjusting variable names
reepoi Jun 22, 2022
03e7dcf
Merge branch 'master' of github.com:reepoi/pvlib-python into townsend…
reepoi Sep 11, 2022
0d1542f
changing eqn 3 percentage loss to fractional loss and adding comment …
reepoi Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Se to effective_snow
  • Loading branch information
@reepoi
reepoi committed Jun 7, 2022
commit e2c1f76aa5d9d2bac10e5bd4d7f733bab8bc5caa
2 changes: 1 addition & 1 deletion pvlib/tests/test_snow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_dc_loss_nrel():
assert_series_equal(expected, actual)


def test__townsend_Se():
def test__townsend_effective_snow():
snow_load = np.array([10, 10, 5, 1, 0, 0, 0, 0, 0, 0, 5, 10])
snow_events = np.array([2, 2, 1, 0, 0, 0, 0, 0, 0, 0, 2, 3])
expected = np.array([7.5, 7.5, 5, 0, 0, 0, 0, 0, 0, 0, 3.75, 6.66666667])
Expand Down
0