8000 Correct cloud_cover_to_transmittance_linear documentation by JoLo90 · Pull Request #1370 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]

Skip to content

Correct cloud_cover_to_transmittance_linear documentation #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/sphinx/source/whatsnew/v0.9.1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ Testing

Documentation
~~~~~~~~~~~~~
* Fix documentation return error in :py:meth:`pvlib.forecast.ForecastModel.cloud_cover_to_transmittance_linear`
(:issue:`1367`, :pull:`1370`)


Requirements
~~~~~~~~~~~~
Expand All @@ -41,3 +44,4 @@ Contributors
* Christian Weickhmann (:ghuser:`cweickhmann`)
* Kevin Anderson (:ghuser:`kanderso-nrel`)
* Adam R. Jensen (:ghuser:`AdamRJensen`)
* Johann Loux (:ghuser:`JoLo90`)
13 changes: 7 additions & 6 deletions pvlib/forecast.py
Original file line number Diff line number Diff line change
Expand Up @@ -512,10 +512,10 @@ def cloud_cover_to_irradiance_clearsky_scaling(self, cloud_cover,
def cloud_cover_to_transmittance_linear(self, cloud_cover, offset=0.75,
**kwargs):
"""
Convert cloud cover to atmospheric transmittance using a linear
model.
Convert cloud cover (percentage) to atmospheric transmittance
using a linear model.

0% cloud cover returns offset.
0% cloud cover returns "offset".

100% cloud cover returns 0.

Expand All @@ -524,14 +524,15 @@ def cloud_cover_to_transmittance_linear(self, cloud_cover, offset=0.75,
cloud_cover : numeric
Cloud cover in %.
offset : numeric, default 0.75
Determines the maximum transmittance.
Determines the maximum transmittance. [unitless]
kwargs
Not used.

Returns
-------
ghi : numeric
Estimated GHI.
transmittance : numeric
The fraction of extraterrestrial irradiance that reaches
the ground. [unitless]
"""
transmittance = ((100.0 - cloud_cover) / 100.0) * offset

Expand Down
0